search

CatimaLoyalty / Android

Catima, a Loyalty Card & Ticket Manager for Android
https://catima.app
GNU General Public License v3.0
858 stars 152 forks source link

Hide Card ID for binary content? #1824

Open leoheitmannruiz opened 6 months ago

leoheitmannruiz commented 6 months ago

Hey :)

First off: Thanks for all the great work!! I used to just keep images of barcodes in my gallery, but Catima is soo much nicer. Especially that the screen brightness is automatically set to max when viewing barcodes!

I've got an aztec barcode, whose content is binary gibberish. I wonder if it makes sense not to show the content/card id below the barcode in such cases. It seems desirable to me, as (in my case) half of the characters are weird and the other half aren't displayed correctly. Not very pretty. I might be missing something, but generally I don't see a point in showing binary data.

What do you think?

TheLastProject commented 6 months ago

Yeah, it makes sense to hide binary. Just wondering what to do instead. Hide it completely? Show some text like "View barcode" you can still tap like with non-binary values?

And of course, detecting binary will be its own challenge.

leoheitmannruiz commented 6 months ago

Not sure either.

I'm tending towards having some text you can tap to show the Card ID.

Mainly to be consistent in having text under the barcode and in case someone wants to compare the content of the barcode generated by Catima with the original? Otherwise I don't really see a use case for showing it.