search

CatimaLoyalty / Android

Catima, a Loyalty Card & Ticket Manager for Android
https://catima.app
GNU General Public License v3.0
809 stars 146 forks source link

Please add GS1_128 barcode type (for UK Nectar cards) #43

Closed TheLastProject closed 3 years ago

TheLastProject commented 3 years ago

Issue by jaimet Tuesday Mar 19, 2019 at 12:55 GMT Originally opened as https://github.com/brarcher/loyalty-card-locker/issues/299

According to this issue comment, "this application will not be able to support GS1_128 barcodes" (as zxing is currently unable to generate this type).

I have a (UK-issued) Nectar card and when I scan the card using "Capture card", the generated barcode does not match the barcode on my Nectar card. Comparing the 2 images to those created by online barcode generator websites, it appears as though loyalty-card-locker is creating a "Code-128" barcode while the real (scanned) card is a "GS1-128 (UCC/EAN-128)" barcode.

Is there any way round this? Many thanks.

(The next time that I'm in store, I'll see whether any of the other barcodes shown under "Edit card" work. Hopefully, I won't arouse suspicion by futzing with their checkout machine for 10 minutes! :laughing::laughing::laughing:)

edit: I've just found https://stackoverflow.com/a/34538369/3499840 ("ZXing does support GS1-128...")

TheLastProject commented 3 years ago

Sorry, I don't really understand this well. From my web searches, GS1_128 is actually just a CODE_128 but not all CODE_128 values are valid GS1_128 values but the other way around is seemingly true.

Does CODE_128 not just work?

github-actions[bot] commented 3 years ago

This issue is missing necessary information and cannot be worked on in its current state. It has therefore been closed to keep the issue tracker clean. If you have more information, feel free to reopen it.