Password protection of app

[TheLastProject]

Issue by MPK44 Saturday Jul 25, 2020 at 08:51 GMT Originally opened as https://github.com/brarcher/loyalty-card-locker/issues/370

---

it would be cool, if one could protect the app with a password from opening. Especially when saving gift card codes (like money)

[TheLastProject]

Comment by brarcher Saturday Jul 25, 2020 at 16:12 GMT

---

There was a request similar to this on another app that I've written. Feel free to review that discussion. Likely it is something that will not be supported in this app. The effort is non-trivial to do it correctly and securely. These days I do not have much time to dedicate to the project.

I thank you for the suggestion, though.

[TheLastProject]

Maybe https://github.com/mattsilber/applock is worth considering for this, it looks promising

[trymeouteh]

+1 for an optional passlock

[Unreal-Dreams]

@TheLastProject Can I take up this issue. I am planning to use the Aitorvs finger lock library {https://github.com/aitorvs/fingerlock} to add the finger lock.

[TheLastProject]

Sounds good! Good luck @Unreal-Dreams and tell me if you have questions :)

[TheLastProject]

@Unreal-Dreams are you still working on this?

[Unreal-Dreams]

I am sorry @TheLastProject due to some unforeseen conditions I won't be able to complete my work on this. I will surely resume if I got a chance. Thank You

[aditya3901]

This is what was supposed to be done right? I'd like to work on this issue. (ps: gif above, will take time to load.)

[TheLastProject]

Yup, that is indeed the requested feature :)

If this becomes optional (so, it doesn't show when you start the app but you can tap something in settings) that would be right about perfect :)

[aditya3901]

App Lock | Catima Debug

Have a look. Will this work?

[TheLastProject]

That looks pretty good!

I think we should avoid showing cards until the app is unlocked (if locking is enabled) and I'd rather the configure lock stuff shows up as soon as you toggle App Lock in the settings.

Will need to try it out myself to see if it feels right, but it looks really good so far :)

[aditya3901]

Should I do locking/un-locking stuff in a separate activity then? (For not showing cards) I don't want to mess with the existing code!

[TheLastProject]

It may be easiest to just extend https://github.com/TheLastProject/Catima/blob/15ba15c602bbed2c3aee18cd5a128c3ee742a67e/app/src/main/java/protect/card_locker/MainActivity.java#L396

to add an if(mDB.getLoyaltyCardCount() > 0 && !appIsLocked()) and just make sure to call the updateLoyaltyCardList function after unlocking

[aditya3901]

App Lock v2 | Catima Debug

Have a look please.

[TheLastProject]

Looks awesome!

How does it deal with stuff like home screen widgets?

[aditya3901]

I was making the pr. The app builds fine and everything. But due to this error, the pr is showing conflict with main branch. What should I do?

[TheLastProject]

There is no error in your screenshot?

[aditya3901]

Line 1 : com.github.spotbugs... github showing error

[TheLastProject]

Nah that's just some weird Android Studio glitch. It shows that as red for me too, but it works just fine. Has been like that for very very long.

[aditya3901]

Ok. Pls check the pr then.

[TheLastProject]

For those who are viewing this issue now:

The last attempt at fixing this was in #462 but sadly it didn't quite work out. So this feature still doesn't exist. For now I'd recommend just using a device-wide lock code (which I strongly recommend doing anyway, if you don't have any lock code on your device you make a lot of private data very easy to reach if someone steals your phone, including all your contacts and photos).