search

CatsAndBoats / catseyexi

:sailboat: LandSandBoat - a server emulator for Final Fantasy XI. Just an X-34 landspeeder out for a drive.
https://landsandboat.github.io/server/
GNU General Public License v3.0
12 stars 13 forks source link

Regional item casket fix #330

Closed MowFord closed 5 months ago

MowFord commented 5 months ago

What does this pull request do?

Regional items were only given to CW and MMM items added to the regional item pool for everyone else, but this logic never worked properly due to an issue in the if check, so if a player was not CW, they would never get regional/MMM items due to an early exit in the code

I've opted to remove any customizations from the casket loot lua and move all logic into caskets.lua. The logic is somewhat simplified and also won't give the MMM item if the player already has it (so someone farming this can eventually get their regional item)

Steps to test these changes

github-actions[bot] commented 5 months ago

✨ Thanks for the PR! ✨

This is a friendly automated reminder that the maintainers won't look at your PR until you've properly completed all of the checkboxes in the pre-filled template.