search

CatsArmy / SpaceSunShine

MIT License
2 stars 0 forks source link

Config For Disabling Lights #8

Closed Ssencipe closed 6 months ago

Ssencipe commented 6 months ago

As counterproductive as it is to the primary function of the mod, it would be great if the lights could be disabled. This is for 2 reasons: The lights currently conflict with Celestial_Tint, which replaces the space props with new lit ones (it is insane, check it out), and some people would still like the ladder and floodlights available despite the lights now being a detriment.

Ssencipe commented 6 months ago

Oops

CatsArmy commented 6 months ago

Huh Celestial Tint? Is that from a mod? @Ssencipe

Ssencipe commented 6 months ago

@CatsArmy Yes, rather new, but it turns the space prop into this animated emulation of a moon scene, except in orbit. Upon further testing, it seems the effect is minimal on the newer light setting. The other reports I've seen seem to have issues with the old sun. Technically you could just leave it I believe, but I'll leave it up to you to close the issue since there are benefits to future-proofing the mod. Here is a link to the mod page for reference: https://thunderstore.io/c/lethal-company/p/sfDesat/Celestial_Tint/

CatsArmy commented 6 months ago

Yeah I can probably do that can't say when as I've got lots of tests in the next few weeks

Ssencipe commented 6 months ago

Fair I totally get it. I'll go through and update everyone who claimed to have issues before on how to fix it. Good luck on exams.

CatsArmy commented 6 months ago

Thanks. By the way if this is a real issue you should probably send this issue to LethalExpansion as it also adds this feature and more

Ssencipe commented 6 months ago

Got it. By the way, it seems in my testing I neglected to test the interior of the ship. It seems both this mod and CelestialTint together do multiply internal ship lighting too much and make the inside look weird. Again, it can wait until you're done with exams, but just wanting to keep you fully up to date with the incompatibilities.

CatsArmy commented 6 months ago

atm im working on splitting up the actual mod as if you look at the github you can find multipule mods of mine so im working on migrating to the new LC template and also improving it for me needs i might be able to do it in the weekend

CatsArmy commented 6 months ago

added in 1.3.0