Closed treister closed 3 years ago
Turns out this is more than a "minor defect". That missing return
is actually undefined behaviour, and is caussing issue #10 !
And, this is the correct fix since the proper function signature is indeed void (*stop)(void *data, uint64_t ts);
: see
I'm not sure why we didn't get warnings from output_info.stop = v4l2sink_stop;
when clearly the function definition didn't match ?
Tried this fix on Arch. Works perfectly for me. No more segfaults when stopping capturing. (Although, on Arch, the "Aur" package has to be build manually and against obs-studio-25.0.3, so the Aur package has to be fixed. But this is not related to obs-v4l2-sink)
I am getting this same issue, after building with the seemingly correct code, I get the same error, and when I try to start the virtual webcam in obs, with the setting "YUV420" it gives me a segfault. what is the solution, thanks
Minor defect when compiling.