organise datastore extension classes in single files

[gravesti]

Would it make sense to gather the class definition and methods for the CSV and duckdb into a single file each: eg datastore_duckdb.R tests/tests-datastore_duckdb.R

• [x] te_datastore_duckdb class defintion
• [x] methods
  • [x] read_expanded_data
  • [x] save_expanded_data
  • [x] sample_expanded_data
• [x] saveto* constructor
• [x] tests

You will need to have a roxygen tag with includes to make sure that the generics and classes are defined.

#' @includes te_datastore.R generics.R
NULL

Should we have a singled help page for all of these things? ie one for duckdb, one for csv You can use @rdname or @describeIn

[darkgoldenrod-cherry]

Didn't move te_datastore_datatable class, methods and tests, didn't move sample_expanded_data for te_datastore_csv since this method is currently shared with te_datastore_datatable, see overview (grey cells indicate no change): https://docs.google.com/spreadsheets/d/1M3xdht1mASg546RZISI_rbfcXBCLuGdA0S7xdVaH73A/edit?usp=sharing

[gravesti]

Thanks, I think that looks good. Maybe we can still have one sampling tests for csv in that test-datastore_csv file for completeness.