search

CausticLab / rgon-proxy

the base image of the rancher nginx-letsencrypt proxy
5 stars 1 forks source link

Add nginx.conf vhost override capability #7

Closed emcniece closed 7 years ago

emcniece commented 7 years ago

gzip_types should be moved to the server{} scope.

Implement vhost file inclusion: example

Munsio commented 7 years ago

https://github.com/CausticLab/rgon-proxy/blob/dev/examples/rancher-gen/nginx.tmpl#L162-L166 this is already in the template so we can close this one

emcniece commented 7 years ago

Should we still move gzip_types into the server{} directive?

Munsio commented 7 years ago

as i told - per default i would remove this from the template himself and add it maybe in the default one cause sometimes those gzip things can break stuff.

Also a paramter we have forgotten is server_tokens off; to not display nginx server-version on error sites