Open goatchurchprime opened 6 years ago
Is the source code for Footleg’s converter available anywhere? I can modify it, but I will be doing so blind, as I’m not a paperless surveyor. I can test any changes by grabbing a .top
file from expofiles
though.
Source code here http://wscc.darkgem.com/caveconverter/releases/source/
From: Philip Withnall notifications@github.com Sent: 29 July 2018 14:48:04 To: CaveSurveyGIS/CUCCexposurveyissues Cc: georgebreley; Assign Subject: Re: [CaveSurveyGIS/CUCCexposurveyissues] Splays shouldn't have named stations (#31)
Is the source code for Footleg’s converter available anywhere? I can modify it, but I will be doing so blind, as I’m not a paperless surveyor. I can test any changes by grabbing a .top file from expofiles though.
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/CaveSurveyGIS/CUCCexposurveyissues/issues/31#issuecomment-408679003, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmcwrIaE5eFHng3TLe_LLZqLb26D94e0ks5uLb0UgaJpZM4VlKXR.
Thanks George. It appears to be on GitHub too: https://github.com/Footleg/caveconverter
That makes things a bit easier.
Although is it really the right fix to change caveconverter? Aven knows that those legs are splays (from the flags), so why can’t it hide the station names? From the point of view of the Survex file, surely it’s marginally more useful to have identifiers for all the splays than to have them all anonymous? I know I certainly sometimes find it useful to be able to cross-reference legs/splays by ID between plan and elevation views when drawing up.
Anyway, it seems caveconverter already supports anonymous splays, but only in its command line version. The GUI version is hard-coded to use flagged, named splays.
To use anonymous splays with the command line version, it looks like you need to run it something like:
java -jar CaveConverter.jar input.top output.svx p s splays anonsplays
I don’t have the time to dig into the GUI and work out how to add a checkbox for outputting anonymous splays from the GUI, but if you care strongly about that then you could submit an issue against caveconverter.
Alternatively, if there’s a strong rationale for using anonymous splay stations in caveconverter (other than “it’s easier to change caveconverter than it is to change Aven”), it would be fairly straightforward to change the GUI so it always outputs anonymous splay stations rather than named ones. Presumably Footleg chose to have them named by default for a reason, though.
I think the naming of splays is probably historic, survex used to not understand anonymous splay
Andrew
On Fri, 3 Aug 2018, 23:15 Philip Withnall, notifications@github.com wrote:
Alternatively, if there’s a strong rationale for using anonymous splay stations in caveconverter (other than “it’s easier to change caveconverter than it is to change Aven”), it would be fairly straightforward to change the GUI so it always outputs anonymous splay stations rather than named ones. Presumably Footleg chose to have them named by default for a reason, though.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CaveSurveyGIS/CUCCexposurveyissues/issues/31#issuecomment-410390191, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvN3ZfSBcDw2fA-ZIQSjqhW9Zf6vrk5ks5uNMuRgaJpZM4VlKXR .
There's a bit of an explosion of station names when previewing in Aven, which is also turning the sections into christmas trees of nodes when you highlight them.
This is because you're using Footleg's top->svx converter which implements the splay legs like this:
Now, we already have a good way to represent splays as anonymous stations, which you can see from 258/themendips.svx:
You'll notice how much easier it is to see how things are connected when you highlight "the_mendips" vs higlighting "mudslope" in Aven.
Is it possible to go back to this format before too many more TOP files get converted? Either by fixing the Footleg converter, or using the Tunnel converter (load the TOP file and copy-paste out the text that is in the big dotted green 'S').
It should be possible to write a script to correct the files already there, to substitute on every line: "(\d+)\s+(\d+)([a-z])" to "\1 -" when \1 == \2 so the damage is not irreversible. These files are easily identified because they shout "BEGIN" instead of "begin" at the start like they've been designed by a FORTRAN programmer -- even though they lack the logical inclusion of "*instrument distox" in them.
Any connection to a splay station is an error.
The only kind of non-stations that should be stations are the proposed QM-type -- which is a GREAT hack, BTW.