search

Cavein254 / mobile-first

https://mobile-first-vert.vercel.app
MIT License
0 stars 1 forks source link

Peer-to-peer code review #6

Open DRT-DISABLED-ACCOUNT opened 1 year ago

DRT-DISABLED-ACCOUNT commented 1 year ago

Hello John, we would like to express our appreciation for the impressive work you have accomplished in your JavaScript code. However, we have noticed that your project is not functioning as expected in Google Chrome and other browsers. To address this issue, we recommend incorporating a CSS reset. This would prevent the default values of the browser from interfering with the styles that you have implemented.

Please find below an example of a CSS reset that you could utilize in your project:

* {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
  list-style: none;
  text-decoration: none;
}

By Juan and Juan David 👍

JuanDBta commented 1 year ago

Hey John, nice work until now! It looks the enormous effort you have put on this project...please review the indentantion of your js file in order to have better professional practice code...it will help you in your future work as developer. I hope this suggestions would be useful for you, have a nice day!

Cavein254 commented 1 year ago

@JuanDBta & @wwwdrt Thanks for the suggestion. I will implement your recommendations in the project.