search

Cavenfish / autogamess

This is a python module for automating Raman calculations using GAMESS(us).
MIT License
9 stars 8 forks source link

Cleaner importing #14

Closed Andrew-S-Rosen closed 5 years ago

Andrew-S-Rosen commented 5 years ago

In general, it is not typically advised to import all your modules from one or two parent modules like is done with from .config import *. If you need to use os in a given .py file, for instance, you should just import os in that file. Otherwise, it is hard for someone unacquainted with the code to figure out what is/isn't imported.

This does not need to be fixed for acceptance, but I just wanted to pass it on to help with code development going forward.

Andrew-S-Rosen commented 5 years ago

(Closed because it's not really an issue!)