search

Cavewhere / cavewhere

3D Cave Mapping Software
https://cavewhere.com
GNU General Public License v3.0
34 stars 8 forks source link

Clino imported as 9.93923e-17 from Walls data treated as an error in data editor #92

Open jedwards1211 opened 8 years ago

jedwards1211 commented 8 years ago

I'm guessing that the editor uses some builtin float to string conversion, which uses exp notation for minuscule values, and that notation fails the validation regexp

Would we consider the underlying floating point value valid or is the intention for there to be a limit on how small a value can be?

screen shot 2015-12-15 at 12 30 21 pm screen shot 2015-12-15 at 12 30 32 pm

vpicaver commented 8 years ago

I wonder if we should do some sorta rounding. I was also wondering if we should store the data as string's instead of double's...

On Tue, Dec 15, 2015 at 1:36 PM, Andy Edwards notifications@github.com wrote:

I'm guessing that the editor uses some builtin float to string conversion, which uses exp notation for minuscule values, and that notation fails the validation regexp

Would we consider the underlying floating point value valid or is the intention for there to be a limit on how small a value can be?

[image: screen shot 2015-12-15 at 12 30 21 pm] https://cloud.githubusercontent.com/assets/1448194/11819885/e57d1ed6-a327-11e5-9bbc-ba841210a79c.png [image: screen shot 2015-12-15 at 12 30 32 pm] https://cloud.githubusercontent.com/assets/1448194/11819886/e583e07c-a327-11e5-856a-26a8804c10de.png

— Reply to this email directly or view it on GitHub https://github.com/Cavewhere/cavewhere/issues/92.

jedwards1211 commented 8 years ago

Huh. I'll leave that up to you. In any case, do you want me to do any rounding in the Walls importer?

vpicaver commented 8 years ago

Not yet, I think I want store data entry as strings. Then well round from there if we need to. I've had some serious issues with floating point issues in editor.

On Tue, Dec 15, 2015 at 7:51 PM, Andy Edwards notifications@github.com wrote:

Huh. I'll leave that up to you. In any case, do you want me to do any rounding in the Walls importer?

— Reply to this email directly or view it on GitHub https://github.com/Cavewhere/cavewhere/issues/92#issuecomment-164947949.