search

Cazsius / Rope-Bridge

Mod that adds Rope Bridges!
GNU Lesser General Public License v2.1
1 stars 9 forks source link

[Bug][1.3PR] Rope-Bridge may randomly break /help command #1

Closed Aedda closed 7 years ago

Aedda commented 7 years ago

As reported by HelpFixer, Rope-Bridge incorrectly overrides compareTo() on 2 help commands. Most likely returning a default of 0 rather than the actual compare result.

[05:00:08] [Server thread/WARN] [com.matthewprenger.helpfixer.HelpFixer]: Command [ropebridge, com.mrtrollnugnug.ropebridge.RopeBridgeCommand] incorrectly overrides compareTo: %s [05:00:08] [Server thread/WARN] [com.matthewprenger.helpfixer.HelpFixer]: Command [ropebridge, com.mrtrollnugnug.ropebridge.RopeBridgeCommand] incorrectly overrides compareTo: %s

Morpheus1101 commented 7 years ago

Has this issue been fixed?

Aedda commented 7 years ago

This issue is not fixed as of the 1.4.0 update 4 hours ago. However according to the commit history Darkhax has fixed the issue in source.

LewisMcReu commented 7 years ago

The command was removed, and when readded will be fixed. As for now, this issue is irrelevant.