When i die with a gravestone mod the hearts dissapear

Cazsius / Spice-of-Life-Carrot-Edition

Motivating people to explore new foods with the carrot, not the stick.

GNU Lesser General Public License v2.1

15 stars 43 forks source link

When i die with a gravestone mod the hearts dissapear #106

Open Okbutwhyohwhytho opened 3 years ago

Okbutwhyohwhytho commented 3 years ago

So as the mod said the hearts are supposed to be infinite, I downloaded a gravestone mod aswell as this mod, I died like we all do in minecraft and I ate some food and it dint save my progress with the hearts I had to start all over. Even when I got to my grave and got my stuff back, the hearts did not return, this repeated 2 more times with similar results, even the connect command thing that is supposed to connect it the the game better did not return my gained hearts.

juliand665 commented 3 years ago

Hi! Thanks for taking the time to report, but we're gonna need a bit more to go on here:

Which version of Minecraft?
Which version of this mod?
Which gravestone mod and which version of that?
Does it happen with just that mod and ours?

Okbutwhyohwhytho commented 3 years ago

1, im playing 1.16.4

the file name / version is: solcarrot-1.16.3-1.9.9.jar
Gravestone version: gravestone-1.16.3-2.0.2.jar Gravestone mod link: https://www.curseforge.com/minecraft/mc-mods/gravestone-mod
the issue doesn't seem to appear with only these two mods, i think it must be another mod in the pack that stacks the normal health and the golden hearts caused from golden apples, i looked through the mod list and I could not locate said mod.

juliand665 commented 3 years ago

I see. In order to work on the problem, I really need to reproduce it on my end. But I can't do that unless I know which mod is involved. If you want this to move forward, ideally you'd systematically go through your mods and figure out which one is causing it. It's possible the gravestone mod isn't even involved!

To locate the mod in question, I'd recommend choosing a good chunk of mods and removing it (maybe around half). If that fixes the issue, you know the mod causing the issue is in that chunk you removed, otherwise it's likely in the rest. You can repeat this with smaller chunks until you've narrowed it down to (hopefully) a single mod :)

tanyan-tanyan commented 3 years ago

Can confirm this also happens on ATM6 in 1.16.5, which has Gravestone and Tombstone mods (not sure what the other one does).

tanyan-tanyan commented 3 years ago

1, im playing 1.16.4

the file name / version is: solcarrot-1.16.3-1.9.9.jar

Gravestone version: gravestone-1.16.3-2.0.2.jar Gravestone mod link: https://www.curseforge.com/minecraft/mc-mods/gravestone-mod

the issue doesn't seem to appear with only these two mods, i think it must be another mod in the pack that stacks the normal health and the golden hearts caused from golden apples, i looked through the mod list and I could not locate said mod.

Do you happen to have Botania or Cyclic in your modpack? I can just about recall that the two mods add hearts from their items so might be worth taking those away if relevant

willtarax commented 3 years ago

There is a config option to reset hearts on death. Make sure this is not set to true.

Dryelo commented 3 years ago

This happened to me as well playing Enigmatica 6 (plus some manually added mods).

The book still remembers the foods I've eaten and (I think) says how many hearts I gained.

SoL-Carrot-1.16.5-1.10.1 I use Simple Tomb v1.16.5-1.0.7 https://www.curseforge.com/minecraft/mc-mods/simple-tomb/screenshots

Botania (according to tanyan-tanyan) and Astral Sorcery are in this pack. They add hearts as well but I haven't progressed that far in these mods to get additional hearts.

After losing the hearts, I ate more individual foods to reach the next milestone. This resulted in me losing half a heart as maximum, so now I'm capped at 9.5 hearts.

I don't know how this would be reproducable. It doesn't happen every time I die.

edit: I tried the /foodlist sync command, did not change anything

juliand665 commented 3 years ago

The book still remembers the foods I've eaten and (I think) says how many hearts I gained.

Hm, that's especially strange. Our code literally does not have the possibility to give you half hearts of max health, so something else seems to be modifying player max health. In another world/instance, I'd recommend testing what happens when you remove our mod from the pack. Does your max health go back to 10? What if you re-add it then?