client connection crashing, MC 1.16.5

Cazsius / Spice-of-Life-Carrot-Edition

Motivating people to explore new foods with the carrot, not the stick.

GNU Lesser General Public License v2.1

15 stars 43 forks source link

client connection crashing, MC 1.16.5 #115

Closed NoX-programer closed 3 years ago

NoX-programer commented 3 years ago

When player respawns at the bed (after death, after dragon win & return), client connection drops with connection crashed.txt

Java v11 Minecraft v1.16.5 Forge v36.1.32 modpack Stacia Expert

But problem appears only with mohist server core.

juliand665 commented 3 years ago

Thanks for the report! Some questions:

Are you able to join back after this occurs?
When you say it appears only with mohist, does that mean it doesn't happen if you run the server as a normal forge server without mohist?
Does it still happen with just mohist and our mod?

NoX-programer commented 3 years ago

Yep. Right after that disconnect
Correct - it is not appears with forge server core
Yep, it happens when there is only your mod & mohist (server-console-error.txt)
And it not happens without any mods with mohist

juliand665 commented 3 years ago

Interesting. To me, this makes it pretty clear that this is an issue with mohist and not our mod. Mohist should behave just like regular forge to mods, and here it does not. It looks like it's not transferring capabilities to respawned players, at least not fast enough.

NoX-programer commented 3 years ago

I'm already switched back to regular Forge (because not only of this one) so it' not a problem for me anymore, but, if you want to make your mod more widely compatible, you can dig deeper, debug and apply fix. Btw, mohist can be multithreaded server, and this can cause the issue.

juliand665 commented 3 years ago

I see. Well, thanks for making us aware, anyway! I'll go ahead and close this unless someone else complains, especially since I'd say the onus is on Mohist to fix this.

Column01 commented 3 years ago

I too have this issue with Mohist + Spice of life. After looking at the player data, I assume the issue is because the food list is supposed to be reset on death (Since that's what it's configured to do) but it doesn't. Internally, SOL registers it as reset but it never actually happens, causing this issue.

Column01 commented 3 years ago

Should be noted it also happens after you go to eat again after the first rejoin

Column01 commented 3 years ago

Running /foodlist clear seems to fix it until you die again

juliand665 commented 3 years ago

Yeah, I'm leaving this closed because I'd say it's Mohist's fault—they should be behaving like vanilla; we shouldn't have to work around their shortcomings. Thanks for the research though!

Romaindu35 commented 3 years ago

This is a know bug with mohist and will be soon fix. This bug is not related to this mod in particular, but to a modification of how forge works

Ashley123477 commented 2 years ago

i believe this is fixed on mohists end now, but i believe there is a new bug in mohist which resets all your previously eaten foods which in turn resets all your hearts

juliand665 commented 2 years ago

Thanks for the update! Nothing but issues with them, lol, but I get it—it's a complex undertaking.

Ashley123477 commented 2 years ago

Amazing software, just a ton of bugs to iron out :)