search

Cazsius / Spice-of-Life-Carrot-Edition

Motivating people to explore new foods with the carrot, not the stick.
GNU Lesser General Public License v2.1
17 stars 43 forks source link

Correctly specify dependency #132

Closed Griefed closed 2 years ago

Griefed commented 2 years ago

A mods dependency should be delcared in the format of dependencies.modId where modId correlates to the id from the preceding [[mods]]-map.

This also helps me identify the sideness of the mod, as seen here https://github.com/Griefed/ServerPackCreator/issues/70

juliand665 commented 2 years ago

Thanks for all 5 of these PRs! I'm afraid we don't update older versions outside of absolutely critical fixes, but I'll go ahead and merge them all (and probably put out a 1.18 update). If this is a common issue, perhaps you could work around it by leniently parsing mods.tomls to accept people putting their dependencies at the top level rather than nesting them under their modid?

Griefed commented 2 years ago

Thanks for all 5 of these PRs! I'm afraid we don't update older versions outside of absolutely critical fixes, but I'll go ahead and merge them all (and probably put out a 1.18 update). If this is a common issue, perhaps you could work around it by leniently parsing mods.tomls to accept people putting their dependencies at the top level rather than nesting them under their modid?

Heyo, yeah I already catch as much as possible in terms of different ways people specify their dependencies, and trust me, it's chaos out there.