search

Cazsius / Spice-of-Life-Carrot-Edition

Motivating people to explore new foods with the carrot, not the stick.
GNU Lesser General Public License v2.1
15 stars 43 forks source link

1.20.1 solcarrot crashes #156

Open funnycubeguy opened 3 weeks ago

funnycubeguy commented 3 weeks ago

why do you maintain this mod if you can't maintain it? forge servers have been plagued with this random crash for a long time...

https://pastes.dev/9uwMTKAkKT

would prefer this mod to be dead so modpacks do not add it... such a pain

juliand665 commented 3 weeks ago

First of all, that crash is not really "one bug" to fix. Many possible issues manifest as that specific crash because it just means that the player's food data is missing when it's queried. This could mean that some process isn't preserving our data on the player (Immersive Portals used to have this issue), it could mean that we're querying our data at a point in time where it's not present yet but will be there soon, and all this in the context of interactions with other mods where we don't know if it's them or us misbehaving.

The alternative to crashing in this case would be to just ignore it and pretend the player simply hasn't eaten any food. This might lead to players silently losing their food lists without any indication that something went wrong. Perhaps crashing is too extreme, but it at least notifies you immediately so you can trace back what you did right before the crash that triggered this.

As for me being a maintainer, I'd love to get rid of that role! The mod brings in an extremely modest amount of revenue (I don't know my exact revenue share, but Cazsius and whoever else was involved before me probably get the majority) so it's hard to justify spending my limited free time on something I'm not really rewarded for, especially since I rarely play Minecraft anymore and have certainly never run into this bug myself. The problem is that we'd have to find a new maintainer to continue in my place. I'm at least here to fix critical issues with clear paths to reproduction & resolution.

Hope that helps :) If you want to help too, you can describe what you were doing that might have triggered the crash and ideally reproduce it with as few other mods involved as possible (Vanilla would be amazing and clearly a critical bug to fix; mod interactions make everything more complicated).

spammer559 commented 1 week ago

i do not know what causes it or how to replicate but it happens so often on public servers same crash log every time