CcMarc / AbuseIPDB

AbuseIPDB integration for Zen Cart
Other
2 stars 2 forks source link

log folder setting... #3

Closed proseLA closed 1 year ago

proseLA commented 1 year ago

do you not think it would be easier to remove the setting ABUSEIPDB_LOG_FILE_PATH? why not just use DIR_FS_LOGS?

i think simpler is better, and the idea that there would be a separate log folder for these logs seems... well... i do not know...

and if one wanted a separate folder, why not make the change the configuration to make it a sub-folder off the DIR_FS_LOGS directory?

proseLA commented 1 year ago

it looks like that config value is not defined when needed...