CecerMCProjects / NoChangeTheGame

A Fabric based Minecraft modification for modern versions that reverts behaviour changes since Minecraft 1.8.9 that are often disliked by PVP players. Intended for use on Hypixel only.
https://www.cecer1.com/projects/nochangethegame/
MIT License
11 stars 2 forks source link

Invisible Shield makes SkyBlock worse #8

Closed Fluboxer closed 4 months ago

Fluboxer commented 5 months ago

Ima be short. There is Hypixel. There is SkyBlock at Hypixel. There are tools at Hypixel that DOES NOT slow you down or have shield at all. However, enabling invisible shield enables it even for weapons that should not have it Disabling invisible shield option fixes that obviously, but you lose on invisible shields

Current things I found that should NOT have invisible shield: all wither blades with ability "Wither Impact", all katanas (this one and it's upgrades), aspect of the end. There may be more

Cecer commented 5 months ago

There isn't really a way to automate this but I can likely just have a list of SkyBlock item IDs that don't handle blocking. I assume this issue isn't specific to this mod but also impacts pre-1.9 versions?

Fluboxer commented 5 months ago

On 1.8 those items do block, yes, as they are all swords. Not having it is one of very few reasons why people were getting modern versions before skyblocker got big

I can go and collect items tho for wither impact you need to either check components for it or description as telling apart clean hyperion from one with wither impact from id.... I doubt that this is easily doable

Cecer commented 5 months ago

When you have time, would it be possible for you to show me these items so I can collect some technical values from them?

Fluboxer commented 5 months ago

ofc

I can also just go to 1.20.4 where there are proper mods capable of dumping NBT and just give you dumps of it

Fluboxer commented 5 months ago

actually ima do it anyway. Those are NBT dumps from 1.20.4: aspect of the end.txt atomsplit katana.txt wither impact Astraea.txt

Cecer commented 5 months ago

Thanks! The structure of item data changed in 1.20.5 but I think I've been able to make it work. Are there other items that don't show a shield when blocking?

I currently check for "ASPECT_OF_THE_END", "VOIDEDGE_KATANA", "ATOMSPLIT_KATANA" and Wither Impact (which I believe is just the combination of "WITHER_SHIELD_SCROLL" + "IMPLOSION_SCROLL" + "SHADOW_WARP_SCROLL" ability scrolls based on the wiki)

Fluboxer commented 5 months ago

Also VORPAL_KATANA

Ima go post this in skyblocker discord in case we both forgor anything

upd: изображение

lunaynx commented 5 months ago

Yeah, why not just disable blocking for any sword item while on SkyBlock?

Cecer commented 5 months ago

I'd really prefer to keep the blocking exception to places where the server also has an exception.

I have gone through the wiki and come up with this list of unblockable sword items. Do any of these look out of place? Can you think of any that are missing? (Checked items have been verified to be unblockable in modern versions)

lunaynx commented 5 months ago

I'm pretty sure sword blocking has never done anything on SkyBlock. It may work visually on older clients because the server can't exactly stop it, but it has practically zero effect.

Cecer commented 5 months ago

The shield style blocking still shows for standard swords on modern versions. I found a Rogue Sword on a very old coop profile and confirmed that it does not show the shield style blocking when right clicking. So it is certainly handled as a special case on the items rather than the game as a whole.

Fluboxer commented 5 months ago

I'm busy next few days but I after that I can go and check this list

criteria is shield appearing?

Cecer commented 5 months ago

Yep! If the shield appears in modern vanilla, that means the server considers the player to be blocking. The closer we match what the server is expecting the better in my opinion.

Thanks for your help with this by the way. It's obviously not something I can easily test given I don't play SkyBlock :P

lunaynx commented 5 months ago

My bad, I didn't realize Hypixel actually implemented the shield thing for swords without abilities in SkyBlock. A bit surprising, because I've never seen sword blocking ever be useful in the game, but it makes sense to follow that then.

I can confirm the shield does not appear for:

It does appear for the following items, whose abilities aren't right-click:

lunaynx commented 5 months ago

Also confirmed to have no shield:

Cecer commented 5 months ago

FYI: I've removed GIANT_CLEAVER too as I believe it falls into the same category of HYPER_CLEAVER and SUPER_CLEAVER.

Fluboxer commented 5 months ago

ATOMSPLIT_KATANA - no shield. Also should have no shield on other katanas I listed FLORID_ZOMBIE_SWORD - no shield (which buffs it a lot for burst healing). Also should have no shield on lesser versions of itself GOLEM_SWORD - no shield. Can't be spammed https://wiki.hypixel.net/Blade_Of_Dragonfire - does not exist GIANTS_EYE_SWORD - unobtainable (does not exist) LIVID_DAGGER - no shield. Can't be spammed Also for whole 6 entries for both blaze slayer daggers - those should have no shield either. I tested it on twilight dagger - daggers are same-ish in terms of ability and they all upgrades of each other

Fluboxer commented 5 months ago

I lack Giant's Sword and Shadow Fury to test tho

Cecer commented 5 months ago

I've marked the following as unobtainable in the list above. I'll probably leave them as "no-shield" items in the mod for the time being though.

I've marked the following items as verfied in the list above.

I've marked the following as untested in the list above.

Any issues these changes?

Fluboxer commented 5 months ago

STARRED_SHADOW_FURY and SHADOW_FURY are same thing. Same goes for yeti sword FELTHORN_REAPER is BONE_REAVER upgrade ASPECT_OF_THE_JERRY_SIGNATURE is same as AOTJ (just 1 rarity up + cursed enchant) and it probably have no shield if AOTJ don't

ima test NECROMANCER_SWORD, WITHER_CLOAK, LEAPING_SWORD and SCORPION_FOIL later

Cecer commented 5 months ago

While essentially the same thing, the wiki states they have different SkyBlock item IDs which is what I am checking against so I added them both to the list. Thank for all the testing by the way!

Fluboxer commented 5 months ago

Necromancer Sword - no shield Wither Cloak - no shield Leaping Sword and Silk Edge Sword - no shield Scorpion Foil - DOES HAVE SHIELD. In fact it is a part of its mecanic. I would be quite amused as it is unique thing - if this sword wouldn't be useless

iirc we lack SF, Felthorn, Giant's and Yeti (and their family)

also 1.21 is out and so most mods, including skyblock ones

Cecer commented 5 months ago

Thanks :) I've made note of those results. As for 1.21, it's on my radar. I'd like to get this and #5 in for it too. Time has just been a little tighter recently.

Cecer commented 4 months ago

I'm happy to assume the rest of the swords in the list should not block based on their wiki descriptions. This should be part of v1.1.0 (for Minecraft 1.21).

Thanks very much for your help with this!

Cecer commented 4 months ago

Release Candidate: https://github.com/CecerMCProjects/NoChangeTheGame/releases/tag/v1.1.0-rc3 (I'll probably release tomorrow)