search

CederGroupHub / LimeSoup

LimeSoup is a package to parse HTML or XML papers from different publishers.
MIT License
19 stars 7 forks source link

[Springer]"Acknowledgements" is supposed to be parsed or not? #32

Closed zhugeyicixin closed 5 years ago

zhugeyicixin commented 5 years ago

When do we include "Acknowledgements" and when not? For example, "10.1007/s10562-010-0490-1" has "Acknowledgements" part while "10.1007/s00339-013-8138-9" does not. Most failures in the unit test are due to "Acknowledgements". @IAmGrootel

IAmGrootel commented 5 years ago

I think the preferred behavior should be to remove acknowledgements. I've made another pull request that I think solves the issue (at least in the test cases).

hhaoyan commented 5 years ago

Well, I guess for other parsers we do parse acknowledgements. Are there any specific reasons to exclude them at all?

OlgaGKononova commented 5 years ago

@hhaoyan I don't quite understand why do we keep acknowledgements as well as list of References and table contents.

hhaoyan commented 5 years ago

I do not understand as well. Then let’s remove them!

hhaoyan commented 5 years ago

@IAmGrootel Please mark this issue closed if you believe it has been solved. Thank you!