search

CederGroupHub / chgnet

Pretrained universal neural network potential for charge-informed atomistic modeling https://chgnet.lbl.gov
https://doi.org/10.1038/s42256-023-00716-3
Other
226 stars 61 forks source link

Unused `get_loader()` #30

Closed janosh closed 1 year ago

janosh commented 1 year ago

Can we delete get_loader()? Looks like it's an unused utility function.

https://github.com/CederGroupHub/chgnet/blob/b59d371b4dd32b872e5a7e303aacfe3b8f31b94d/chgnet/data/dataset.py#L720-L744

BowenD-UCB commented 1 year ago

It's occationally used to separately load val dataset and test dataset. Let's keep it