search

Ceeresa / autocertificazione

Genera velocemente la tua autocertificazione
https://covidcert.it
9 stars 2 forks source link

Feature/add tags to form inputs #221

Closed tom139 closed 3 years ago

tom139 commented 3 years ago

fixes #220 by adding autocomplete and spellcheck tags in forms.

DavidePastore commented 3 years ago

Hi @tom139 ! Thanks for your contributions! Could you please start from and also target to the develop branch? Let me know if you need help in this sense 😄

tom139 commented 3 years ago

Ehi @DavidePastore, yep, no problem. I thought main and develop were identical but it is not the case. I will close this PR and open a new one, referencing the same issue.

tom139 commented 3 years ago

@DavidePastore I've seen there is some issue with the html validation action. I'm checking the code I pushed and will comment again as soon if I have an update.

DavidePastore commented 3 years ago

Yes @tom139 . It seems the validator is not expecting some additional HTML attributes. In the meantime I'm working on enabling the html_check workflow even on PR, so we can easily get the output of it before merging.

tom139 commented 3 years ago

Great for PR validation 👍🏽. I've found that autocorrect is listed among non standard attributes as a Safari-only extension in the Mozilla documentation.

DavidePastore commented 3 years ago

The validation should be enabled on PRs too.

I've found that autocorrect is listed among non standard attributes as a Safari-only extension in the Mozilla documentation.

In this case we could remove it.

DavidePastore commented 3 years ago

@tom139 , it seems that autocomplete="street-address" is related to the textarea tag and cannot be used for input type="text". Check it here.

tom139 commented 3 years ago

What do you suggest for street-address? I will change it to address-line-1, let me know if you think it is better to change the input to a textarea.

Regarding the Safari only autocomplete tag I will remove it.

DavidePastore commented 3 years ago

Thanks @tom139 . I think that for the moment it's ok to use address-line-1.