Ceiridge / Chrome-Developer-Mode-Extension-Warning-Patcher

⇒ Disable Chrome's Developer Mode Extension Warning Popup & Elision & Manifest V3 webRequestBlocking limitations
GNU General Public License v3.0
454 stars 33 forks source link

[New feature request] Trapezoid tabs patch #21

Open oleedd opened 4 years ago

oleedd commented 4 years ago

Can you please try to return back the option for the trapezoid tab design to Chrome? image This option was available in UI layout => normal at chrome://flags. But the normal parameter was removed in Chrome 71. This problem was very discussed. Many users decided to use an old Chrome version because of the new tab design. I hope for you. That can make this patch much popular. Please try.

Ceiridge commented 4 years ago

I can try to find this flag in the new source code, but it's very likely that the old design was just entirely removed. Additionally, more ui elements became round in the newer versions (like the omnibar / url bar, the bookmarks, etc.)

I couldn't find the old design in the source code ( https://source.chromium.org/chromium/chromium/src ) You can either get used to the better new design or you keep on using your old unsafe and outdated version that doesn't support many new features.

Ceiridge commented 4 years ago

But I think I should keep this open if somebody else finds a better solution

oleedd commented 4 years ago

Another new elements are not so important.

it's very likely that the old design was just entirely removed

Is it theoretically possible to put removed code back (it can be found in Chromium 70)?

Ceiridge commented 4 years ago

Yes, but that's practically impossible.

oleedd commented 4 years ago

It can be seen what they removed. I think the easiest is replacing the new design with old. So it will not require new space. But it is not so clear. So what are difficulties in?

Ceiridge commented 4 years ago

I don't have the source code for Brave/Chrome, but only for Chromium, on which the popular browsers are based on. I could practically make a fork of Chromium and add the old design, but it wouldn't have the Chrome-only features. And I wouldn't do that, because it's too much effort for something I don't profit off of.

It's practically impossible to add new compiled code to existing binaries, because the size would change and this would break the section headers and probably every function call. Besides that, I would then have to find empty code spaces or something for every browser executable for every new version. And most importantly of all: I would need to add the old design code again and the Chromium source code is unbelievably big and it would just take too much time to get it to work.

The current patcher only finds some patterns of bytes and changes some. This slightly changes the executed code, but adding new features wouldn't be practical.

oleedd commented 4 years ago

I could practically make a fork of Chromium and add the old design

I tried to find one but all I tried are without this option. But I am also for Chrome-only features.

The important thing is where the tab designs are stored. Do you know?

the size would change and this would break

Yes, I thought so. What about just replacing (as they did) without changing the size?

Ceiridge commented 4 years ago

Please re-read my comment above. It's not all about the size

oleedd commented 4 years ago

I have read attentively several times before. I don't understand what you exactly mean. Repeating for new versions? (Anyway, it is the easiest because it will be already known how to do it and in what fragments. Chrome doesn't change a lot. So I think such thing even can work automatically - in a good case.) Now I start to think that replacing designs is quite good because users need only one - (in this case) the old design. And it shouldn't require searching free space - so it is much easier.

Ceiridge commented 4 years ago

I'm not trying to be unfriendly, but it's still practically impossible as I've mentioned. If you want the old design in the new Chrome versions, you will need to ask some other reverse engineer to implement it or you do it by yourself, although I doubt that there will by any reverse engineer willing to do this.

Ceiridge commented 4 years ago

This might be more time efficient for you: https://www.wikihow.com/Get-Rid-of-Bad-Habits

oleedd commented 4 years ago

or you do it by yourself

I want very much. But there are very few guides about that. So I learn something new very slow. Now I see almost all about finding warning strings in crackme. I didn't find anything about adding new code/features or changing work of programs.

I don't understand the sense of your link about habits.

Darthagnon commented 4 years ago

I almost came here to ask the same thing as the OP. Thank you for making this amazing patcher!

For future readers' reference, the last versions of Chromium iirc with the old tabs are:

NB all the above versions require flags setting to enable the trapezoid tabs.

Ceiridge commented 4 years ago

Thanks, but I'm only keeping this issue open for any other coders that maybe want to add it somehow, because this is not a feature that is added easily. Probably, multiple kilobytes would have to be changed in the binary and I'm clearly not going to do that.

Darthagnon commented 4 years ago

I read through the thread, and understand that it's impossible. Just thought I'd add links to the final versions of Chromium with the tabs, in case someone in the future stumbles across this thread and decides to take a look, or for the OP, should he wish to go to a "golden version".

whoave commented 2 years ago

please somebody add this feature back to chromium

Darthagnon commented 9 months ago

Supermium v121 added back trapezoid tabs to Chromium v121, and it's compatible with Windows all the way back to Windows XP: https://github.com/win32ss/supermium/releases/tag/v121

See also chrome tabs css/js

OleExploder commented 1 month ago

Supermium v121 added back trapezoid tabs to Chromium v121, and it's compatible with Windows all the way back to Windows XP: https://github.com/win32ss/supermium/releases/tag/v121

I know this reply was from January but I think the only small problem here is that the trapezoid tab design included in Supermium isn't the exact one that is found in for instance Chromium 49 or Chromium 61 though it is absolutely way better than nothing and it would likely be impossible to add the exact layout back in a modern version of Chromium anyway with how Google drastically changed it over the years.