Chapter 2: Implementation

[CejkaLuk]

Notes related to this chapter can be found in Notion: Thesis Structure.

General draft & post-supervisor quality points to check

Grammar, Spelling, etc.

• [x] Address and remove TODOs (including \TODO)
• [x] Hyphenation:
  • [x] "non-zero" is not as popular -> use "nonzero" instead
  • [x] Replace all "sub-" prefixes with "sub" (for example: "sub-optimal" -> "suboptimal" - correct according to the Oxford dictionary)
• [x] Full stops and commas:
  • [x] Full stops and commas after equations if the equations are part of a sentence
  • [x] Thousands separated by comma
• [x] Bullet points
  • [x] That are meant to be a part of the sentence should be separated by a comma and the last bullet should have a dot at the end (if it ends the sentence)
  • [x] Consistent formatting, e.g., if they're individual sentences -> colon + capital letter right after. If they're part of a sentence, then colon + small letter right after.
• [x] Titles of Chapter/Section/etc. follow correct capitalization
• [x] Double-check spelling using TeXstudio and Grammarly

  Text formatting

• [x] Numbers in the text must not be in math mode
• [x] References to sections etc. have a capital letter in the text (Section~\ref{}, Figure~\ref{}, Table~\ref{})
• [x] Quotes, or statements in "" should be italicized
• [x] No indented line after an object that slices a text in two
• [x] Use "" for multiplication only in in-line code, e.g., `U = R I`
• [x] Mathematics formatting:
  • [x] Variables in cursive font
  • [x] Constants in non-cursive (using \mathrm{})
  • [x] Do not use "*" for multiplication in math mode as it signifies convolution
  • [x] Use \mathbf{} for matrices and vectors (\mathbb{} is used for sets)
  • [x] Shortcuts in sub- and super-script should not be in cursive, e.g. X^{new} "new" should not be cursive)
  • [x] \nonumber\,. should be before newline
• [x] Code formatting:
  • [x] Courier font and grey background (in-line and code block)
  • [x] Check code in all lstlistings for correct syntax highlighting
  • [x] Code blocks:
  • [x] Consistent spacing in code - Do: for( int... i++ ); Don't: for ()
  • [x] Consistent formatting of {} - Do: void func()\n{ \n}; Don't void func() { \n}
  • [x] No spacing from the left part of the listing
• [x] Citations in the text:
  • [x] Spaces between text and citations
  • [x] Multiple citations must be in one \cite{a, b, c} command, not \cite{a}\cite{b}\cite{c}
• [x] Variables in cursive font, e.g., ICMx (x can be one of 8, 16, 32)
• [x] Consistent label names
  • Template: {Type:chapter->section->subsection->subsubsection->specific-content-name}
• [x] No line overflowing (text, in-line code, etc.)
• [x] Consistent footnotes - they must either contain URL if a Url follows, or not.
  • Made some exceptions

    Low priority

• [x] TiKZ Figures:
  • [x] Either convert the necessary figures to TiKZ OR create an issue to fix a specific figure
  • Some papers include the TiKZ source code

Post-supervisor checks quality points

• [x] Remove any \TO

[CejkaLuk]

Will not send it to the supervisor until he has corrected the 1st chapter. Reason: so that I can apply the comments he has to the 1st chapter to this 2nd chapter.

[CejkaLuk]

Found issues in implementation while gathering metrics for #3.

• [x] Update code.
  • [x] Read Chapter 2 again and rewrite ICMxPP according to the new implementation.
  • [x] Check if edits are needed for the ICMPP algorithm in Chapter 1 -> add to issue if yes.
  • [x] Rename any (_)new to next
  • [x] Rename any new_(row|col) to (row|col)_adj
• [x] Update code coverage.
• [x] Replace the text in Grammarly and make final edits.
• [x] Fix title of IS_xPP appendix chapter

[CejkaLuk]

Errors spotted:

• [x] Missing explanation of __host__ and __device__ when __cuda_callable__ is introduced.
• [x] cuSolverDnXgetrf should have a capital first letter to be consistent with the benchmark results.
• [x] Finalize the name of CuBLAS and CuSolver -> all should be the name of the class (wrapper)
• NO: Explain the threads per block of the ISxPP solver in `\paragraph{Iterative Solver With Partial Pivoting (IS\\textit{x}PP)}`
  • It is explained in the Listing presenting the implementation as it makes more sense to include it there - it is an implementation detail.
• [x] Tables should follow the formatting of Tables in Chapter 03
  • \rowcolor[HTML]{C0C0C0} in the title
  • Column names in bold
  • NO: Use cursive instead of bold to denote that a procedure was implemented by the author.
  • The variable x in ICM_xPP would not be distinguishable.
  • NO: Highlight in grey the full row of the procedure that will be discussed in the thesis.
  • It looks bad.

[CejkaLuk]

Supervisor review

Page-specific

• [x] Page 44:
  • [x] Use HPC instead of GPGPU
• [x] Page 45:
  • [x] Double-check the grammar of "only a select few"
  • Confirmed OK by Grammarly, and Ludwig (searched through various articles and papers).
• [x] Page 49:
  • [x] Double-check the grammar of the "Point-of-failure testing", while it may be correct, it sounds weird.
  • Replaced with a clearer sentence.
  • [x] Remove the zeros in the date - unnecessary.
  • Replaced with a different date format.
• [x] Page 53:
  • [x] Double-check the grammar of the "it depends on are not processed", while it may be correct, it sounds weird.
  • Reworded the sentence.
• [x] Page 54:
  • [x] Bad element clarification
  • It is not intuitive in what it represents - either explicitly define it before or rename it to something like "Bad Pivot Candidate"
  • [x] Define it before the explanation of the algorithm.
• [x] Page 63:
  • [x] Rephrase "matrix multiplication is performed without exceptions" - it is confusing, the "exception" may refer to a C++ exception or smthn.
  • You're trying to say that the figure depicts full matrix multiplication, i.e., an entire row column is multiplied by an entire column.

General

• [x] Use "ones" instead of "1s" in the thesis - it is safer and better to be consistent.
  • [x] Pages: 44, 46