search

Celebr8 / frontend

This is the frontend of Celebr8.co
Apache License 2.0
4 stars 7 forks source link

Add a "recommand a pub" form to Contact Us #211

Open lcoenen opened 5 years ago

lcoenen commented 5 years ago

What's the improvement:

To add the fields in the Contact form in order for users to be able to use it to Recommend a Pub through it when they choose that option.

How should it look like (screenshot or sketch):

The questions that need to be considered for the 'Recommend a pub' are:

How should it work (write use case):

All questions above are mandatory.

Priority (tag accordingly): Regular Domain (tag accordingly): Frontend Tested on: (platform, OS, browser, version) Windows, latest, Chrome, latest Branch: Staging

Work on it

Validate

Please follow https://github.com/Whichost/frontend/wiki/Git-workflow

betahope commented 5 years ago

What's the improvement:

To add the fields in the Contact form in order for users to be able to use it to Recommend a Pub through it when they choose that option.

How should it look like (screenshot or sketch):

The questions that need to be considered for the 'Recommend a pub' are:

  • What's your Whichost account email? (or we can pull this info if they are logged in)
  • What's the name of the pub?
  • In which country is the pub located? (dropdown options: Ireland, Northern Ireland (UK), England (UK), Scotland (UK), Wales (UK), Other option so people can also recommend in other countries)
  • In which city/town/village is the pub located?
  • Please, indicate the reason why you are recommending the pub. (dropdown options: To request a booking and make use of the Birthday Gift, To request a booking and make use of the Corporate Benefit, To request a booking and make use of the Recommend Reward, Just because... :) )

How should it work (write use case):

All questions above are mandatory.

Priority (tag accordingly): Regular Domain (tag accordingly): Frontend Tested on: (platform, OS, browser, version) Windows, latest, Chrome, latest Branch: Staging

Work on it

  • Derive the branch from staging.
  • Tag with ongoing and move the card to ongoing.
  • Develop the feature
  • Commit your work
  • Create a PR and ask for validation. Move the card to staged.
  • Ask for validation.
  • Close the issue if all the work have been done

Validate

  • Check on mobile and on desktop if the feature have been correctly implemented.
  • If everything is working fine, move the card toaccepted column.
  • If the feature isn't completely implemented, re-open the issue with a comment clearly what the problem is and what is the desired result. Move the card to have issues column.

Please follow https://github.com/Whichost/frontend/wiki/Git-workflow

@lcoenen

I've update the issue with the questions for the Recommend a Pub form.

Thanks 👍

lcoenen commented 5 years ago

@RohrerHope Do you mind if I do the following modifications? :)

betahope commented 5 years ago

@RohrerHope Do you mind if I do the following modifications? :)

  • We already have the email address of the user in the Contact Us form.
  • The name will be mandatory.
  • There will be an autocomplete for the address to replace country / village fields.
  • The wording of the select is too long and redundant ("To request a booking and ..."). Maybe we can think of something more direct? (I admit that I don't have ideas right now).

@lcoenen Good morning,

Go ahead! Especially the address autocomplete, that's great that we can use that.

For the wording of the select field, here's a proposal:

Thanks 👍