search

CelestiaProject / Celestia

Real-time 3D visualization of space.
https://celestiaproject.space
GNU General Public License v2.0
1.83k stars 308 forks source link

Remove size limit for eclipsing satelites #114

Open 375gnu opened 5 years ago

375gnu commented 5 years ago

A user's request

375gnu commented 5 years ago

This issue is created on Celestia Origin team request. The current code in Celestia doesn't render shadows if:

  1. The object's radius is much smaller (0.5%) than the object shadows are drawn on, or
  2. The object isn't an ellipsoid, i.e. it has a model.

As Ceelstia Origin has a lot of models used instead of default ellipsoids, they have implemented a workaround: they add an ellipsoid to every model so that ellipsoid casts shadows.

So they want this workaround added into Celestia so that every model has virtual shadow casting ellipsoid inside (obviously that shadows will be elliptical).

I'm not a fan of this approach, but on the other hand, we don't have enough knowledge yet to build proper shadows. So unless somebody qualified joins the team we should add this workaround.