Askaniy commented 1 year ago

Screenshots

Desktop

OS: Linux (openSUSE Tumbleweed + KDE 5.27 + Wayland)
Frontend: Qt 5
Version: 1.7.0 b0f40cec084d85ce767e35d9f2d344fe12b72be1

levinli303 commented 1 year ago

probably same issues as #1551

375gnu commented 1 year ago

if you revert #1594 does it help?

git revert 69be12027e30d60d7861f6c6954cb15e4d1c4a01

Askaniy commented 1 year ago

Can't revert it easily, I use compiled versions provided by this repository.

munix9 commented 1 year ago

I will try to test it this weekend, but my hardware is currently a bit unstable.

Have you tested the AppImage? It is basically the same code base, but compiled under openSUSE Leap 15.4 - maybe you get a different result.

Askaniy commented 1 year ago

I hope I did what you meant. It seems to work there. screenshot

munix9 commented 1 year ago

Yes, that's what I meant, thank you. Now we know that in general it works on openSUSE, but on Tumbleweed apparently there is "currently" a problem. openSUSE Tumbleweed is a rolling release, so it is quite possible that a new os component/library can cause problems. Let's see if I get something out this weekend.

munix9 commented 1 year ago

Ok, I can reproduce it:

openSUSE Tumbleweed 20230223 Celestia 1.7.0~git20230224+15df4ba

In a Plasma-X11 session the display is correct. In a Plasma-Wayland session the rendering of the clouds is wrong, i.e. without transparency.

This is both with celestia-qt and with celestia-qt6. With celestia-sdl the display is correct again in Plasma-Wayland.

If I start celestia-qt or celestia-qt6 with $ QT_QPA_PLATFORM=xcb celestia-qt the display is correct again, because then X11 is used for Celestia in the Wayland session.

For further details/testing, I need more instructions from the pros here on how to proceed.

In the meantime, celestia-qt or celestia-qt6 can be started and used as described above with the environment variable QT_QPA_PLATFORM=xcb.

The tests were done in a VMware environment, as I currently have a major problem running Celestia natively on my aged notebook: Shortly after startup, the entire computer freezes and only powering off/on brings it back to life. I'll open a new issue about this when I have more info.

package list

munix9 commented 1 year ago

Another test, but the result does not necessarily help to find a solution:

I install weston, the Wayland Reference Compositor, start it in a Plasma-X11 session and then inside weston a console is started and here again I start celestia-qt.

And here the transparency works normally again. I can't make any sense of it right now.

$ sudo zypper in weston
The following 7 NEW packages are going to be installed:
  libfreerdp2-2 libseat1 libweston-11 libweston-11-0 libwinpr2-2 vpx-tools weston
$ weston

Inside weston from the top left start a terminal and then $ celestia-qt

levinli303 commented 1 year ago

please post the render info panel compiled with the latest commit.

munix9 commented 1 year ago

OpenGL version: 3.3 (Compatibility Profile) Mesa 22.3.5
Vendor: VMware, Inc.
Renderer: SVGA3D; build: RELEASE; LLVM;
GLSL Version: 3.30
Max simultaneous textures: 48
Maximum texture size: 16384
Point size range: 1 - 80
Point size granularity: 0.10
Number of interpolators: 124
Max anisotropy filtering: 16.00

Supported extensions:
GL_ARB_multisample
GL_EXT_abgr
GL_EXT_bgra
GL_EXT_blend_color
GL_EXT_blend_minmax
GL_EXT_blend_subtract
GL_EXT_copy_texture
GL_EXT_subtexture
GL_EXT_texture_object
GL_EXT_vertex_array
GL_EXT_compiled_vertex_array
GL_EXT_texture
GL_EXT_texture3D
GL_IBM_rasterpos_clip
GL_ARB_point_parameters
GL_EXT_draw_range_elements
GL_EXT_packed_pixels
GL_EXT_point_parameters
GL_EXT_rescale_normal
GL_EXT_separate_specular_color
GL_EXT_texture_edge_clamp
GL_SGIS_generate_mipmap
GL_SGIS_texture_border_clamp
GL_SGIS_texture_edge_clamp
GL_SGIS_texture_lod
GL_ARB_framebuffer_sRGB
GL_ARB_multitexture
GL_EXT_framebuffer_sRGB
GL_IBM_multimode_draw_arrays
GL_IBM_texture_mirrored_repeat
GL_ARB_texture_cube_map
GL_ARB_texture_env_add
GL_ARB_transpose_matrix
GL_EXT_blend_func_separate
GL_EXT_fog_coord
GL_EXT_multi_draw_arrays
GL_EXT_secondary_color
GL_EXT_texture_env_add
GL_EXT_texture_filter_anisotropic
GL_EXT_texture_lod_bias
GL_INGR_blend_func_separate
GL_NV_blend_square
GL_NV_light_max_exponent
GL_NV_texgen_reflection
GL_NV_texture_env_combine4
GL_S3_s3tc
GL_SUN_multi_draw_arrays
GL_ARB_texture_border_clamp
GL_ARB_texture_compression
GL_EXT_framebuffer_object
GL_EXT_texture_compression_s3tc
GL_EXT_texture_env_combine
GL_EXT_texture_env_dot3
GL_MESA_window_pos
GL_NV_packed_depth_stencil
GL_NV_texture_rectangle
GL_ARB_depth_texture
GL_ARB_occlusion_query
GL_ARB_shadow
GL_ARB_texture_env_combine
GL_ARB_texture_env_crossbar
GL_ARB_texture_env_dot3
GL_ARB_texture_mirrored_repeat
GL_ARB_window_pos
GL_ATI_fragment_shader
GL_EXT_stencil_two_side
GL_EXT_texture_cube_map
GL_NV_depth_clamp
GL_NV_fog_distance
GL_NV_half_float
GL_APPLE_packed_pixels
GL_ARB_draw_buffers
GL_ARB_fragment_program
GL_ARB_fragment_shader
GL_ARB_shader_objects
GL_ARB_vertex_program
GL_ARB_vertex_shader
GL_ATI_draw_buffers
GL_ATI_texture_env_combine3
GL_ATI_texture_float
GL_EXT_shadow_funcs
GL_EXT_stencil_wrap
GL_MESA_pack_invert
GL_NV_primitive_restart
GL_ARB_depth_clamp
GL_ARB_fragment_program_shadow
GL_ARB_half_float_pixel
GL_ARB_occlusion_query2
GL_ARB_point_sprite
GL_ARB_shading_language_100
GL_ARB_sync
GL_ARB_texture_non_power_of_two
GL_ARB_vertex_buffer_object
GL_ATI_blend_equation_separate
GL_EXT_blend_equation_separate
GL_OES_read_format
GL_ARB_color_buffer_float
GL_ARB_pixel_buffer_object
GL_ARB_texture_compression_rgtc
GL_ARB_texture_float
GL_ARB_texture_rectangle
GL_EXT_packed_float
GL_EXT_pixel_buffer_object
GL_EXT_texture_compression_dxt1
GL_EXT_texture_compression_rgtc
GL_EXT_texture_rectangle
GL_EXT_texture_sRGB
GL_EXT_texture_shared_exponent
GL_ARB_framebuffer_object
GL_EXT_framebuffer_blit
GL_EXT_framebuffer_multisample
GL_EXT_packed_depth_stencil
GL_ARB_vertex_array_object
GL_ATI_separate_stencil
GL_EXT_draw_buffers2
GL_EXT_draw_instanced
GL_EXT_gpu_program_parameters
GL_EXT_gpu_shader4
GL_EXT_texture_array
GL_EXT_texture_integer
GL_EXT_texture_sRGB_decode
GL_EXT_timer_query
GL_OES_EGL_image
GL_EXT_texture_buffer_object
GL_ARB_copy_buffer
GL_ARB_depth_buffer_float
GL_ARB_draw_instanced
GL_ARB_half_float_vertex
GL_ARB_instanced_arrays
GL_ARB_map_buffer_range
GL_ARB_texture_buffer_object
GL_ARB_texture_rg
GL_ARB_texture_swizzle
GL_ARB_vertex_array_bgra
GL_EXT_texture_swizzle
GL_EXT_vertex_array_bgra
GL_NV_conditional_render
GL_AMD_conservative_depth
GL_ARB_ES2_compatibility
GL_ARB_blend_func_extended
GL_ARB_compatibility
GL_ARB_debug_output
GL_ARB_draw_elements_base_vertex
GL_ARB_explicit_attrib_location
GL_ARB_fragment_coord_conventions
GL_ARB_provoking_vertex
GL_ARB_sampler_objects
GL_ARB_seamless_cube_map
GL_ARB_shader_texture_lod
GL_ARB_texture_buffer_object_rgb32
GL_ARB_texture_multisample
GL_ARB_texture_rgb10_a2ui
GL_ARB_uniform_buffer_object
GL_ARB_vertex_type_2_10_10_10_rev
GL_EXT_provoking_vertex
GL_EXT_texture_snorm
GL_MESA_texture_signed_rgba
GL_NV_copy_image
GL_ARB_get_program_binary
GL_ARB_robustness
GL_ARB_separate_shader_objects
GL_ARB_shader_bit_encoding
GL_ARB_shader_subroutine
GL_ARB_timer_query
GL_ARB_viewport_array
GL_EXT_direct_state_access
GL_ANGLE_texture_compression_dxt3
GL_ANGLE_texture_compression_dxt5
GL_ARB_compressed_texture_pixel_storage
GL_ARB_conservative_depth
GL_ARB_internalformat_query
GL_ARB_map_buffer_alignment
GL_ARB_shading_language_420pack
GL_ARB_shading_language_packing
GL_ARB_texture_storage
GL_EXT_framebuffer_multisample_blit_scaled
GL_EXT_transform_feedback
GL_AMD_shader_trinary_minmax
GL_ARB_ES3_compatibility
GL_ARB_arrays_of_arrays
GL_ARB_clear_buffer_object
GL_ARB_copy_image
GL_ARB_explicit_uniform_location
GL_ARB_fragment_layer_viewport
GL_ARB_invalidate_subdata
GL_ARB_program_interface_query
GL_ARB_stencil_texturing
GL_ARB_texture_buffer_range
GL_ARB_texture_query_levels
GL_ARB_texture_storage_multisample
GL_ARB_vertex_attrib_binding
GL_KHR_debug
GL_KHR_texture_compression_astc_ldr
GL_ARB_buffer_storage
GL_ARB_clear_texture
GL_ARB_internalformat_query2
GL_ARB_multi_bind
GL_ARB_shading_language_include
GL_ARB_texture_stencil8
GL_EXT_debug_label
GL_EXT_shader_integer_mix
GL_ARB_direct_state_access
GL_ARB_get_texture_sub_image
GL_KHR_context_flush_control
GL_ARB_parallel_shader_compile
GL_KHR_no_error
GL_KHR_texture_compression_astc_sliced_3d
GL_MESA_shader_integer_functions
GL_ARB_texture_filter_anisotropic
GL_KHR_parallel_shader_compile
GL_EXT_EGL_image_storage
GL_EXT_EGL_sync
GL_NV_ES1_1_compatibility

levinli303 commented 1 year ago

need to build with commit 15df4ba

munix9 commented 1 year ago

hm, strange, this is 15df4ba, see https://github.com/CelestiaProject/Celestia/issues/1601#issuecomment-1445047569

levinli303 commented 1 year ago

hmm there should be a line with Color component if it is compiled against https://github.com/CelestiaProject/Celestia/commit/15df4ba74b3ae5364cc470c262da4cbd6c1ebc9c

munix9 commented 1 year ago

Maybe I'm in the wrong place: how exactly do I get the output I want?

munix9 commented 1 year ago

or is the output miising in src/celestia/qt/qtappwin.cpp ? https://github.com/CelestiaProject/Celestia/blob/master/src/celestia/qt/qtappwin.cpp#L1151

levinli303 commented 1 year ago

yeah it is missing there.

munix9 commented 1 year ago

In the meantime, I'll test a local build and revert https://github.com/CelestiaProject/Celestia/pull/1594, maybe it's because of that, as 375gnu noted above. But this will take some time.

levinli303 commented 1 year ago

try adding these to line 1186

    // shading language version
    if (info.count("ColorComponent") > 0)
    {
        out << QString(_("<b>Color component:</b> %1")).arg(info["ColorComponent"].c_str());
        out << "<br>\n";
    }

ajtribick commented 1 year ago

Looking again at #1594 - I think an alternate fix might be to change https://github.com/CelestiaProject/Celestia/blob/15df4ba74b3ae5364cc470c262da4cbd6c1ebc9c/src/celengine/render.cpp#L5410

to use glBlendFuncSeparate(ps.blendFunc.src, ps.blendFunc.dst, GL_ONE, GL_ONE_MINUS_SRC_ALPHA)

this at least stops the Milky Way from changing the framebuffer's alpha. Whether this works for all our transparent rendering is another matter

munix9 commented 1 year ago

Now with "Color component". The only difference between the outputs is

x11: Color component: RGB888 wayland: Color component: RGBA8888

Reverting https://github.com/CelestiaProject/Celestia/pull/1594 did not help.

levinli303 commented 1 year ago

Now with "Color component". The only difference between the outputs is

x11: Color component: RGB888 wayland: Color component: RGBA8888

Wayland has this bug right? Then it is the same as #1551 which we need to fix.

munix9 commented 1 year ago

Wayland, yes, more precisely: Wayland in the current openSUSE Tumbleweed version. According to Askaniy, however, the representation in the AppImage is correct, and this was created with openSUSE Leap 15.4.

I will also run tests in a VM with openSUSE Leap 15.4 (Xorg/Wayland), but I suspect that more recent packages in Tumbleweed are causing the display problems.

munix9 commented 1 year ago

As I suspected: in openSUSE Leap 15.4, Wayland Plasma session, the transparency display is correct.

However, the mouse does not work correctly, I can not rotate the earth - but that is probably another problem.

I have added the patch in https://github.com/CelestiaProject/Celestia/issues/1601#issuecomment-1445086214 to the openSUSE packages and AppImage, these should be available to install soon.

375gnu commented 1 year ago

x11: Color component: RGB888 wayland: Color component: RGBA8888

Reverting #1594 did not help.

X11 behaves correctly with #1594 but wayland ignores request to avoid alpha. This is either wayland or qt bug.

Askaniy commented 1 year ago

It seems better after #1605

Askaniy commented 1 year ago

But now we have aliased edge of the atmosphere and some fade effect (slow motion video)

https://user-images.githubusercontent.com/44873271/221528714-46d5894e-77c4-4434-85bd-f98f015a1226.mp4

upd: it's not an artifact of VA monitor, I compared with the AppImage version from last week

Askaniy commented 1 year ago

The atmosphere is just still transparent: Found a trick to render a window with transparency:

@ajtribick, is it possible to repeat #1605 for atmospheres?

munix9 commented 1 year ago

I still think it's due to current packages (Qt, Wayland) in openSUSE Tumbleweed, as the rendering in Leap 15.4 is correct (AppImage).

Either a bug has crept into the very current packages of Qt/Wayland, or something new in the versions leads to the wrong display.

It is also possible that the problem will be solved in one of the next Tumbleweed versions, but I don't know.

Askaniy commented 1 year ago

This problem sometimes shows up on other platforms, so I think if we are able (?) to fix it now, it may prevent similar bugs in the future.

levinli303 commented 1 year ago

The root cause is known however it might be just hard to fix.

On the frontends i maintain, there's workaround. iOS/macOS native (set layer to opacity), Android/UWP (find an opaque OpenGL config). I don't know if there is similar workaround on QT.

ajtribick commented 1 year ago

Good to see the continents are working for you. I suspect the change I mentioned earlier in this thread to use glBlendFuncSeparate to avoid writing the alpha channel is probably still necessary then, since this also worked for me in solving the transparent image capture issue on Windows. Hopefully will have time to look at this in the next few days.

375gnu commented 1 year ago

@Askaniy please open a terminal and run the following command:

QT_LOGGING_RULES=qt.qpa.gl=true celestia-qt

And then post output here.

Askaniy commented 1 year ago

Celestia launched, no output

ajtribick commented 1 year ago

Is this still occurring since merging #1616?

munix9 commented 1 year ago

On my openSUSE Tumbleweed 20230302 it looks good now (celestia-1.7.0~git20230303+f70fc01-718.1.x86_64), at least what I can see until the computer completely LOCKs.

I had hinted before that my old notebook has been freezing completely for some time when I start Celestia natively. If I start the AppImage it runs.

Let's see if I can debug something there, unfortunately nothing is written in the logs at all (Plasma, Xorg, i915, Intel HD Graphics 4000, Kernel 6.2.1).

Askaniy commented 1 year ago

1616 works well on the latest openSUSE Tumbleweed build 👍

Askaniy commented 1 year ago

Apparently, the topic issue is done, but

Should workarounds be removed on other platforms? Suddenly it will increase performance, but it's just thinking out loud
No output logs on my Linux configuration and on Windows 11 too, and at least 2 more people with no logs on Linux. Probably it should be a new issue

CelestiaProject / Celestia

Transparency render bug #1601

1616 works well on the latest openSUSE Tumbleweed build 👍