search

CelestiaProject / Celestia

Real-time 3D visualization of space.
https://celestiaproject.space
GNU General Public License v2.0
1.76k stars 299 forks source link

`ApplyShadow` result discarded during shader creation #2167

Open ajtribick opened 3 months ago

ajtribick commented 3 months ago

The result of the ApplyShadow call here isn't used.

https://github.com/CelestiaProject/Celestia/blob/b54fa98b0d3a4b4f12887f42210363622f250dea/src/celengine/shadermanager.cpp#L2467-L2469

Need to check what this does and either append the code to source or remove the call.

375gnu commented 3 months ago

oh, source += was lost when ApplyShadow was added to avoid code duplication.