search

CelestiaProject / Celestia

Real-time 3D visualization of space.
https://celestiaproject.space
GNU General Public License v2.0
1.86k stars 309 forks source link

HUD translation contexts #2185

Open ajtribick opened 6 months ago

ajtribick commented 6 months ago

The use of CX_ in hud.cpp seems dubious:

https://github.com/CelestiaProject/Celestia/blob/187570179f14013c5940b22f0f67fea713c030b9/src/celestia/hud.cpp#L1031-L1056

The intention appears to be to allow for translations of object names in the context of phrases like "Follow ", which may differ from the usual display form (e.g. in languages where names vary according to grammatical case). However, the lookup is being done on the "celestia" domain, not the "celestia-data" domain, and the input string is the the already-translated name. Since we do not actually generate such phrases in our translation files, these effectively become a no-op.

375gnu commented 6 months ago

I added this like a reminder, but never implemented this.

  • © Githubissues.
  • Githubissues is a development platform for aggregating issues.