Support fmt 11 - Githubissues

CelestiaProject / Celestia

Real-time 3D visualization of space.

https://celestiaproject.space

GNU General Public License v2.0

1.86k stars 309 forks source link

Support fmt 11 #2225

Closed ajtribick closed 3 months ago

ajtribick commented 3 months ago

Resolves #2223

Bump minimum supported fmt version to 8.0.0 (supply 8.1.1 in thirdparty/fmt)
Use const format functions
Rewrite path formatter to avoid copying on non-Windows systems
Update vcpkg version to latest

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ajtribick commented 3 months ago

@munix9 - could you check if this is working for you, particularly regarding the minimum fmt version bump

munix9 commented 3 months ago

I have built the packages with the sources from https://github.com/CelestiaProject/Celestia/tree/fmt11 :

openSUSE Leap 15.4 (base for AppImages) uses system fmt 8.0.1 openSUSE Leap 15.5 uses system fmt 8.0.1 openSUSE Leap 15.6 uses system fmt 8.0.1 openSUSE Tumbleweed uses system fmt 11.0.2 Debian 11 uses thirdparty/fmt Debian 12 uses system fmt 9.1.0 Ubuntu 22.04 uses system fmt 8.1.1 Ubuntu 24.04 uses system fmt 9.1.0

See https://build.opensuse.org/project/monitor/home:munix9:unstable

LGTM