search

CelestiaProject / Celestia

Real-time 3D visualization of space.
https://celestiaproject.space
GNU General Public License v2.0
1.85k stars 310 forks source link

[1.7.0] Disk models rendered with black squares from some distances #840

Closed SevenSpheres closed 4 years ago

SevenSpheres commented 4 years ago

Describe the bug When viewed from a close distance in Celestia 1.7.0, some (all?) disk models are rendered with a black square around them.

To Reproduce Steps to reproduce the behavior:

  1. Download Vision's Milky Way center addon from here
  2. Go to Sgr A*
  3. See bug

Expected behavior Disks are rendered without black squares, as in 1.6 (and older 1.7 builds)

Screenshots The bug at Sagittarius A* sgrablacksquare Another example from Trolligi image

Desktop (please complete the following information):

levinli303 commented 4 years ago

I will probably investigate into It when I have time. if you got time, can you maybe try with older versions from appveyor so we can see which commit might be the faulty commit?

SevenSpheres commented 4 years ago

Seems to have been caused by #823

levinli303 commented 4 years ago

More specifically, in this commit: https://github.com/CelestiaProject/Celestia/pull/823/commits/8983df3d576bd6e42ee56261102d050ea70f1367

as I add back line 2986/2987 in render.cpp, the issue is gone.

Since I'm no expert in GL, @375gnu how should we fix it

375gnu commented 4 years ago

@levinli303 looks like you have found the root cause.

levinli303 commented 4 years ago

should we add back the two lines or should we revert the commit?

375gnu commented 4 years ago

Just get back those two lines.