search

CelestialCartographers / Loenn

A Visual Map Maker and Level Editor for the game Celeste but better than the other one
MIT License
160 stars 22 forks source link

Add room sorting #38

Closed TheDrawingCoder-Gamer closed 1 year ago

TheDrawingCoder-Gamer commented 1 year ago

Adds room sorting bound by default to pageup and page down.

Still probably has kinks to iron out, but is a good start on room order changing.

Cruor commented 1 year ago

This feature already exists but has not been released yet, in the form of automatic (opt out) room sorting on save. Pull request is targeting the wrong branch, and I disagree with this approach to manual room reordering.

TheDrawingCoder-Gamer commented 1 year ago

Hi Cruor, thanks for listing out why it's listed out like this.

Not sure I agree with ONLY having automatic room sorting. I have a room in my level named "end". If I ever get to chapter e then the auto sorter would probably not sort correctly, no? Having manual sorting as a backup would be nice. Also maps like solaris that have non traditional naming conventions (afaik the chapters are s, o, l, a, r) would be sorted incorrectly.

What branch am I supposed to target? I had heard that Olymp-UI was the main branch so I targeted that (the master branch on my local machine doesn't run as expected, the UI doesn't show up). My edits are fairly minor (only a few files need changed with sorting implemented), so I could easily port them to the correct branch.

In the future if this gets accepted I would like to see drag and drop on the room list but this is quite literally my first experience with LOVE. I'll read up more to see if I can do anything.

Thanks in advance - Bulby