CellProfiler / CellProfiler-Analyst

Open-source software for exploring and analyzing large, high-dimensional image-derived data.
http://cellprofileranalyst.org
Other
146 stars 72 forks source link

Fix crash when no objects are found within a score-all chunk #311

Closed DavidStirling closed 2 years ago

DavidStirling commented 3 years ago

As described on the forum, some users reported that the Score All function crashed with some databases.

Score All runs by breaking the objects list up into reasonably sized segments based on the image number. This crash happened when a particular segment (e.g. ImageNumbers 50-60) contained no objects. The fix should be simply continuing if there's no data to work with.

I've also removed the redundant 'AND 1=1' condition which was being added to queries whenever there was no filter active, because I see no reason to be doing this.

imagesc-bot commented 3 years ago

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/cpa-score-all-indexerror-tuple-index-out-of-range/57856/5