search

CellProfiler / CellProfiler-Analyst

Open-source software for exploring and analyzing large, high-dimensional image-derived data.
http://cellprofileranalyst.org
Other
144 stars 73 forks source link

Fix broken image scoring #328

Open DavidStirling opened 6 months ago

DavidStirling commented 6 months ago

Fixes #327

Looks like something went wrong when implementing 3D mode, and the resulting coordinates list to draw onto images was being clipped to the first two elements.

GetObjectsCoords should only ever return 2D coordinates for objects as they're being mapped onto images. It appears that an attempt was made to have it return 3D, but this was only applied to the query portion rather than the downstream data processing. The attempt to round the third coordinate also doesn't appear to work as intended, though this isn't necessary anyway.

To resolve this I've stripped that part of the function out. If 3D mode does need to show position in 3D then feel free to restore, though I can't see anything trying this in the code.

AndyLAMHS commented 4 weeks ago

Hi, I also encountered the issue of "score image" only appear 2 positive 2 negative result using Github downloaded version. Is there anything I could do to circumvent the problem? Thanks.

PS. Is this related to the software unable to connect to Github to update?

螢幕截圖 2024-08-20 上午11 23 51 螢幕截圖 2024-08-20 上午11 25 54
DavidStirling commented 3 weeks ago

Hi @AndyLAMHS, if you don't need 3D processing you could try using version 3.0.3 as a workaround for now.

The update failure message is completely unrelated.