Update RunIJScript - Githubissues

CellProfiler / CellProfiler-plugins

Community-contributed and experimental CellProfiler modules.

http://plugins.cellprofiler.org/

56 stars 67 forks source link

Closed hinerm closed 2 years ago

hinerm commented 2 years ago

This patch includes:

Support for ij.ImagePlus script inputs/outputs
Support for subclasses of net.imagej.Dataset and net.imagej.ImgPlus
Automatic type conversion between CP and IJ, with a setting to disable if desired

hinerm commented 2 years ago

@bethac07 :+1: thank you for the quick feedback!

One thing I somehow didn't catch before is that your module doesn't seem to have a variable_revision_number

Makes total sense. I added an upgrade_settings implementation and it seems to work as intended.

One other super small change -can we change Run ImageJ Script in a couple of places to RunImageJScript

100% of course. I think I got all these.

Let me know if you think of anything else!

alicelucas commented 2 years ago

Just chiming in here to confirm that the updated module still works on my end, AND the output image from our script now looks great :) Thanks Mark! 🎉

bethac07 commented 2 years ago

LGTM! Thanks!