search

CellProfiler / CellProfiler-plugins

Community-contributed and experimental CellProfiler modules.
http://plugins.cellprofiler.org/
56 stars 67 forks source link

CP-IJ: Multiprocessing refactor #144

Closed hinerm closed 2 years ago

hinerm commented 2 years ago

Redesigns the ImageJ connection of the RunImageJMacro to a server communication method, which avoids negative interactions of worker subprocesses on Windows.

Other QOL improvements include:

alicelucas commented 2 years ago

@hinerm @bethac07 just noting that on my machine, running the module now works both in test mode and in analysis mode! We should make sure that it works on @bethac07 's machine as well for the pipeline that she has been using.

@hinerm has pointed out that the module did not work on @gnodar01's machine, so we'll have to do some digging to see what differences we have in our setups and why it didn't work for him.

bethac07 commented 2 years ago

Did we ever sort why this didn't work on @gnodar01's machine? It works well on mine and I'm otherwise ready and happy to pull.

hinerm commented 2 years ago

@bethac07 I don't think so :( I did some debugging with him but and my test case worked for him, so we couldn't figure out what was going on.

I'm not sure that it's critical to identify at this time or not... do you think so? Let me know and I can think about debugging options.