search

CellProfiler / CellProfiler-plugins

Community-contributed and experimental CellProfiler modules.
http://plugins.cellprofiler.org/
54 stars 65 forks source link

CP-IJ: add workaround for Java names #219

Closed hinerm closed 10 months ago

hinerm commented 10 months ago

Required for newer PyImageJ releases (1.4.1) until we have a release with https://github.com/imagej/pyimagej/commit/a1861b6c1658d6751fa314650b13411f956549ab merged.

Closes #218

bethac07 commented 10 months ago

Awesome, thanks for the quick fix!

Quick q just before pulling - will this change hurt for later versions, or will it just be purely defensive there? Just wondering if we will need/want to set our pyimageJ pin to a particular version.

hinerm commented 10 months ago

Quick q just before pulling - will this change hurt for later versions, or will it just be purely defensive there?

Should just be defensive.. most of the time it should do nothing, and should only help if using a pyimagej version that can return Java string names on DataArrays. I am happy to update it to be more defensive if we discover a need at any point.

I think we would only need to pin to a version (or set a minimum) of pyimagej if we want to remove this hack when the next pyimagej version is released.

bethac07 commented 10 months ago

I think we would only need to pin to a version (or set a minimum) of pyimagej if we want to remove this hack when the next pyimagej version is released.

Cool, you let me know if you'd like that to happen then, but for now, will pull!