CellProfiler / CellProfiler-plugins

Community-contributed and experimental CellProfiler modules.
http://plugins.cellprofiler.org/
56 stars 68 forks source link

Create an EnforceObjectsOneToOne plugin [WIP] #242

Closed bethac07 closed 3 weeks ago

bethac07 commented 6 months ago

Replaces #238

We initially looked at putting this functionality into RunCellpose (#227), and a lot of the pseudocode happened there, but in writing this up I realized that a) it was fiddly and b) the more DL segmentation stuff we add, the more we were going to need it, and so I extracted it out into its own module. Initial draft here lacks a display and some documentation but otherwise as far as I can tell is otherwise functional and is creating the correct outputs.

bethac07 commented 6 months ago

@sugan89 identified a case where this is failing, will dig in later but I now have the files to do so

bethac07 commented 6 months ago
image
ErinWeisbart commented 3 weeks ago

Would like to have the third panel of the display image be outlines of the enforced primary and secondary objects superimposed but I don't understand how to make that work so I need help.

Do we ever have module inputs that are only for the display? Because it would be neat to add the functionality of Do you want to see enforced objects superimposed on an image? and then Select image and then having that as the background of the outline image as it would be much easier to see if your new enforced objects make biological sense (without having to use the Workspace Viewer).

bethac07 commented 3 weeks ago

Would like to have the third panel of the display image be outlines of the enforced primary and secondary objects superimposed but I don't understand how to make that work so I need help.

IDSecondary has something like that, perhaps that code will be of use?

Do we ever have module inputs that are only for the display? Because it would be neat to add the functionality of Do you want to see enforced objects superimposed on an image? and then Select image and then having that as the background of the outline image as it would be much easier to see if your new enforced objects make biological sense (without having to use the Workspace Viewer).

Oh @ErinWeisbart , the answer to "do we ever do X in CellProfiler" is ALWAYS yes. In this case, the "display local maxima" setting in IDPrimary

ErinWeisbart commented 3 weeks ago

I still don't understand how, but I did it :) AFAIK this is ready to merge (other than @bethac07 's outstanding comment above about comments being out of order)

bethac07 commented 3 weeks ago

I confess I found some of the descriptions over-mathy, to the point in one or two places I couldn't parse correctness, so I did a small editing pass. If you can live with @ErinWeisbart , please do pull, otherwise, edit as you see fit and then pull!