search

CellProfiler / CellProfiler-plugins

Community-contributed and experimental CellProfiler modules.
http://plugins.cellprofiler.org/
58 stars 67 forks source link

Fix module imports for CP3 #97

Closed DavidStirling closed 4 years ago

DavidStirling commented 4 years ago

Some modules were renamed in CellProfiler 3, which has broken some plugins. I've gone through and updated those import statements. I can't confirm whether the plugins themselves are fully functional, and other non-CP dependencies still need to be added, but at least it's not completely broken.

Fixes #89

bethac07 commented 4 years ago

In general, this is a good idea, but since people still may be using them in older versions, my vote would be to also keep a copy of the pre-update ones in a "CellProfiler2" folder- can you add this here?

DavidStirling commented 4 years ago

That's a very good idea! Do we have a record somewhere of which modules were for CP2? I expect there are others which didn't need the imports fixed that also don't work on CP3.

bethac07 commented 4 years ago

Not explicitly, but all the ones you were updating the imports for would be a safe bet (and any other ones that have "cpimage").

I'm sincerely hoping we won't need to do that for CP3 vs CP4, but if we DO, we'll want to follow the same procedure there (keeping a frozen CP3 copy, then updating the "main" copy to CP4).

On Fri, Mar 20, 2020 at 12:49 PM David Stirling notifications@github.com wrote:

That's a very good idea! Do we have a record somewhere of which modules were for CP2? I expect there are others which didn't need the imports fixed that also don't work on CP3.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CellProfiler/CellProfiler-plugins/pull/97#issuecomment-601802113, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTI7266LD4WC2TJNNUT4I3RIONAXANCNFSM4K7X4Z3A .

-- Beth Cimini, PhD Computational Biologist, Imaging Platform Broad Institute 415 Main St Room 5011 Cambridge, MA 02142 Current office number- (617) 714-8189 Pronouns - She/her/hers I will sometimes send or respond to emails outside of my local office hours, but I never expect responses outside of your local office hours.

DavidStirling commented 4 years ago

@bethac07 I've added a CP2 folder, this should be ready now