Closed nicholsn closed 4 years ago
@nicholsn I just noticed your PR after fixing the same issue you may want to cherry-pick https://github.com/CellProfiler/centrosome/pull/99/commits/80375d2e92f0374b933a3d8a97e399f365d65d04 since that extra comma fails travis
@jburel what branch is that commit on? (also I could just close this since you already fixed it)
git cherry-pick 80375d2
fatal: bad revision '80375d2'
Sorry for the confusion it was on my repository, you will need to keep your PR opened This is the change I indicated https://github.com/jburel/centrosome/commit/80375d2e92f0374b933a3d8a97e399f365d65d04 so you could do something similar in this PR
@nicholsn I have opened a new PR against your branch it removes few more extra commas and it fixes the travis build everything should be green now see https://travis-ci.org/github/jburel/centrosome/builds/680434025
@jburel great thanks, merged and now this is passing!
Any chance to get that PR merge @0x00b1 and have a new release of centrosome? version 1.1.7 is currently broken without the changes in this PR.
@0x00b1 @bethac07 Any chance to get that PR merged and have a new release of this package?
Yep! Thanks everyone! Merging now, will package and release today.
This PR simply drops a comma in setup.py that was causing an installation issue on ubuntu 18.04 with both
pip install centrosome
andpython setup.py install
.pip 20.0.2 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7)
Python 2.7.17
Here is the error that is fixed: