CellProfiler / centrosome

An open source image processing library
Other
18 stars 35 forks source link

Drop comma that causes install to fail #98

Closed nicholsn closed 4 years ago

nicholsn commented 4 years ago

This PR simply drops a comma in setup.py that was causing an installation issue on ubuntu 18.04 with both pip install centrosome and python setup.py install.

pip 20.0.2 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7) Python 2.7.17

Here is the error that is fixed:


Collecting centrosome
  Using cached centrosome-1.1.7.tar.gz (543 kB)
    ERROR: Command errored out with exit status 1:
     command: /usr/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-muJE3W/centrosome/setup.py'"'"'; __file__='"'"'/tmp/pip-install-muJE3W/centrosome/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-install-muJE3W/centrosome/pip-egg-info
         cwd: /tmp/pip-install-muJE3W/centrosome/
    Complete output (6 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-muJE3W/centrosome/setup.py", line 84
        **__extkwargs,
                     ^
    SyntaxError: invalid syntax
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.```
jburel commented 4 years ago

@nicholsn I just noticed your PR after fixing the same issue you may want to cherry-pick https://github.com/CellProfiler/centrosome/pull/99/commits/80375d2e92f0374b933a3d8a97e399f365d65d04 since that extra comma fails travis

nicholsn commented 4 years ago

@jburel what branch is that commit on? (also I could just close this since you already fixed it)

git cherry-pick 80375d2
fatal: bad revision '80375d2'
jburel commented 4 years ago

Sorry for the confusion it was on my repository, you will need to keep your PR opened This is the change I indicated https://github.com/jburel/centrosome/commit/80375d2e92f0374b933a3d8a97e399f365d65d04 so you could do something similar in this PR

jburel commented 4 years ago

@nicholsn I have opened a new PR against your branch it removes few more extra commas and it fixes the travis build everything should be green now see https://travis-ci.org/github/jburel/centrosome/builds/680434025

nicholsn commented 4 years ago

@jburel great thanks, merged and now this is passing!

jburel commented 4 years ago

Any chance to get that PR merge @0x00b1 and have a new release of centrosome? version 1.1.7 is currently broken without the changes in this PR.

jburel commented 4 years ago

@0x00b1 @bethac07 Any chance to get that PR merged and have a new release of this package?

0x00b1 commented 4 years ago

Yep! Thanks everyone! Merging now, will package and release today.