search

CellProfiler / python-bioformats

Read and write life sciences file formats
Other
132 stars 46 forks source link

Fix bug that prevented setting values for "AcquiredDate" attribute #39

Closed hackermd closed 9 years ago

hackermd commented 9 years ago

Also change name of the attribute from "AcquiredDate" to "AcquisitionDate" according to the OME model

hackermd commented 9 years ago

relates to issue #38

LeeKamentsky commented 9 years ago

Hi @HackerMD - I pushed your branch to our repo and committed 0810d75bda9a3ef0f318733a3510d8b28ddf759d (and then merged with master so it would build on Travis). Could you review and cherry pick? Thanks for submitting the request.

LeeKamentsky commented 9 years ago

@HackerMD also 5e0fd6e needs to be merged in.

hackermd commented 9 years ago

I fetched the upstream "acquistion_date" branch, merged it and ran nosetests.py. Looks fine:

...........(640, 640)
.........................................................................................................................
----------------------------------------------------------------------
Ran 132 tests in 24.162s

OK
hackermd commented 9 years ago

Thanks for immediately taking care of it!

LeeKamentsky commented 9 years ago

Can you add my two commits to the pull request? I'll merge after that.

LeeKamentsky commented 9 years ago

Excellent - thanks. LMK if you have any more additions or questions (although I'm out next week).