search

CelliesProjects / ESP32_VS1053_Stream

A streaming library for Arduino esp32 with a vs1053 mp3/aac/ogg/flac decoder. Plays http, https (insecure mode) and chunked streams and parses the metadata. Also plays ogg and mp3 from sdcard.
MIT License
37 stars 9 forks source link

Adding Bass and Treble settings #11

Closed 3KUdelta closed 1 year ago

3KUdelta commented 1 year ago

I added the pass-through for the setTone() function.

CelliesProjects commented 1 year ago

Thanks for your effort!. I saw a possible bug in your code and added a remark. It might take a couple of days before I can find the time to test and merge.

CelliesProjects commented 1 year ago

It tests ok. Two things I would like to see before merging is:

  1. The argument to the function as a const.

void setTone(const uint8_t *rtone);

  1. Could you update README.md with the new function description?
CelliesProjects commented 1 year ago

Looking good. I will probably merge this PR coming weekend. Thanks for your time and effort.