Femtocell Detection: Toast message despite CDMA device

[SecUpwN]

Good evening developers, I have received a message from user "Ted", who mentioned that our warning toast message Femtocell detection is available on CDMA only also comes up on his CDMA device.

Solution:

1. The warning toast message should only appear to unsupported devices, related to #6.
2. Improve code to detect if the device is really supported - if not, display the toast message.
3. Gray out Femtocell Detection (and maybe also Femtocell Protection) if device is unsupported.
4. Replace message (currently CDMA Phones ONLY) with Your device is currently not supported
5. If the device is supported though, use the message Detect connections with Femtocells.

If his logcat is needed (which I think won't be the case for now), drop me a line and I'll send it to you.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[DJaeger]

@SecUpwN: I think I have found a method to detect if CDMA is available, but have to check that some deeper

@E3V3A: But this will still not support ALL devices, right? So why should we drop this?

[SecUpwN]

I think I have found a method to detect if CDMA is available, but have to check that some deeper

Ok, take your time. You may have a look at #6 as well, we have a lot of useful code in there.

So why should we drop this?

This Issue in specific was just about the toast message Femtocell detection is available on CDMA only appearing on a CDMA device which should in fact be supported, but this Issue somehow evolved. I hope my updated OP makes sense to everyone now, when this is fixed we'll move back to work on #6.

[TPS]

I think I have found a method to detect if CDMA is available, but have to check that some deeper

@DJaeger I'm all ears, & ready & willing to test any improvements to this, with my great thanks!

[TPS]

@SecUpwn In https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/issues/457#issuecomment-121217482 , you mentioned

the warning toast appears even though @lop1 is using a CDMA device

Has @lop1 indeed reported having the same issue as myself? If so, I'd really like to hear about it!

[lop1]

But I am not using a CDMA phone ( only pure GSM Galaxy S4 mini )

[SecUpwN]

Has @lop1 indeed reported having the same issue as myself? If so, I'd really like to hear about it!

I might have confused the two of you. Sorry about that. ;-) @DJaeger, you said you had found a method to detect if CDMA is available? Please feel invited to add it so that @TPS can run some tests!

[DJaeger]

I will push it when I find time for it.

[E3V3A]

Read my code comments. Detection of CDMA is mostly broken in AOS...

[TPS]

Hence my facetious comment from ~1 month ago:

Obviously, something so short & straightfoward has no chance of working in the real world.… ;)

[SecUpwN]

I will push it when I find time for it.

Thanks. Don't get stressed though, we'll be patient.

[E3V3A]

Before you start spending time re-coding and so on, you should reconsider this entire femtocell thing. As I've said repeatedly and never enough, femtocells are usually identified with certain ranges of LAC/CIDs so the old code we have can basically be removed without any adverse effect, given that we know each providers LAC/CID ranges they use for Femtocells.

I really hate this Femtocells thing as it is a waste of time, in terms of detections. CDMA already have built-in parameters for exact GPS tower locations, so it would be trivial to compare this to our measurements or OCID DB etc. All without this bloody PITA code.

My suggestion is to completely remove the Femtocell code and rather try to support CDMA better.

[SecUpwN]

Catching up on GitHub. @DJaeger, what is your opinion on E:V:As proposal above? If I understood it right, we could remove any old Femtocell Detection code (and with that the settings from Preferences?) and "kill two flies in one run" when impriving support for CDMA because that would include a proper FemtoCell detection without having to cope with old and unmaintained code? Hope I got that right.

[DJaeger]

If E:V:A is right and the exact location of CDMA towers is delivered by CDMA that would be great. But it's not clear, if Femtocells are also delivering their position. In addition we currently don't have a list with these "ranges".