CellularPrivacy / Android-IMSI-Catcher-Detector

AIMSICD • Fight IMSI-Catcher, StingRay and silent SMS!
https://cellularprivacy.github.io/Android-IMSI-Catcher-Detector/
GNU General Public License v3.0
4.71k stars 943 forks source link

"Toggle Attack Detections" ambigious behaviour in Preferences #578

Open E3V3A opened 9 years ago

E3V3A commented 9 years ago

If you try to disable "Toggle Attack Detections", your choice is not remembered after restart/quitting of app. I suppose we need to save this as a setting somewhere.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

SecUpwN commented 9 years ago

Confirmed. Saving all settings in /sdcard/Android/data/com.SecUpwN.AIMSICD/files/settings.xxx may also enable users and developers to test our app with old settings after a fresh install.

DJaeger commented 9 years ago

@E3V3A: We have a setting in the preferences activity to toggle the autostart of this feature. And it works!? What do you mean?

DJaeger commented 9 years ago

I would suggest to close this, as all is working as expected

SecUpwN commented 9 years ago

I would suggest to close this, as all is working as expected

Agreed. @E3V3A, feel free to re-open this with an extended explanation, should this happen again.

E3V3A commented 9 years ago

I see, the problem is the different names in Preferences, versus on Drawer:

On Drawer:

Toggle Attack Detection
Toggle Cell Tracking

In Preferences:

Cell Tracking
Cell Monitoring

At this point I have no ****ing idea what is what... And if they are the same or different.

DJaeger commented 9 years ago

They are for the same but simply differently named. I also had to test which one in the preferences is for which one in the navigation drawer. In addition they are in reversed order.

SecUpwN commented 9 years ago

They are for the same but simply differently named. In addition they are in reversed order.

I can totally understand @E3V3A's frustration here and am sure users will appreciate a simplification. Maybe removing the stuff from the Preferences and just keeping it in Navigation Drawer will help?

E3V3A commented 9 years ago

Maybe removing the stuff from the Preferences and just keeping it in Navigation Drawer

I agree, but keep it as a remembered "preference" when toggling.

DJaeger commented 9 years ago

We shouldn't have some feature switches in preferences and some in the navigation drawer. I think we should move them all to preferences and let them all act immediately and not only after restart, like it is done already for silent SMS and femtocell detection. This would also make the navigation drawer shorter.

E3V3A commented 9 years ago

Yes and no. You do want a quick toggle for when you're moving around or going inside etc. But at the same time the data will be much less useful if users keep on toggling back and forth without knowing/understanding why...

DJaeger commented 9 years ago

I think it should never be toggled "quick". You should use the feature or not, as you can be a target of MITM everywhere, especially at home!

E3V3A commented 9 years ago

Well, one of the toggles is about collecting the data and requiring GPS...

ga900 commented 9 years ago

If may I suggest to use gps fix flag to turn on-off data collecting? If gps has fix collect data otherwise stop collecting. For detection use position from last fix. Of course option to turn on and off mentioned options in some advanced setup would be nice :).

DJaeger commented 9 years ago

@ga900: we already have an issue for this somewhere

TPS commented 9 years ago

@DJaeger @ga900 Do you both mean #251?

DJaeger commented 9 years ago

@TPS: Yes, thanks.

E3V3A commented 9 years ago

@ga900

... use gps fix flag to turn on-off data collecting? If gps has fix collect data otherwise stop collecting. For detection use position from last fix.

Well, this is where things get a bit hairy... Because, blocking GPS is very easy, we made #309. In addition, we still wanna keep an eye on the connected network info, so please clarify what you mean should happen.

So perhaps:

  1. One toggle should be to log GPS positions or not.
  2. The other to log (in file/db) other events, but not disable warnings about type-0 SMS, changing LAC etc. but only toggle the .

Initially the idea was that one of the buttons should lock the phone into 2G-mode only, for detection. But since then, it seem that LTE provides a better security and the TA, PD parameters needed to better detect an IMSIC, so perhaps the second toggle should be updated to be, kind of, Lock phone to LTE-only?

SecUpwN commented 9 years ago

Erm.. may I drop my own suggestion here as well? How about this:

DJaeger commented 9 years ago

@SecUpwN: But why have them on two locations? And if they are at two locations why not also the others (silent sms, femtocell...) ?

E3V3A commented 9 years ago

That is a good temp solution, but it would be redundant and still confusing with two locations.

ga900 commented 9 years ago

If you lose GPS you probably entered building, home, underground garage, shopping mall or tunnel. Except in longer tunnels, where is expected to have different LACs on entry and exit, in all other places I would expect to stay in the same LAC, so I would use last known position for detection of threats and measurements, but will not upload such measurements to OCID. So I would put toggle "use last known position" when gps signal is lost and "increase detection sensitivity when GPS is lost" so when gps signal is lost any change of LAC or SC is warning for possible catcher. This option may trigger many false alarms if it will be used in U-Bahn. Btw with time preferences will be crowded with different togles, so think about putting different toggles in "Advanced detection setting" menu under detection preferences? Lock to LTE sound like a good idea, but what will hapen if you try to lock to lte where is no lte coverage? How about to check for LTE coverage before locking and if there is no LTE coverage lock to 2G?

agilob commented 8 years ago

Yes @SecUpwN I did understand what you mean. I just don't think it should turn itself on automatically, it causes huge battery drain.

SecUpwN commented 8 years ago

I just don't think it should turn itself on automatically, it causes huge battery drain.

Me neither. But it should remember its previous setting when the app gets restarted!

agilob commented 8 years ago

Why should?

User should decide when to start draining battery and getting GPS-fix.

SecUpwN commented 8 years ago

User should decide when to start draining battery and getting GPS-fix.

Hmm.. you're somehow right as well. My initial thought was that a user could enable protections, accidentally quit our app and re-enter it without knowing that nothing is being analyzed, @larsgrefer, what do you think, would you consider this an Issue or do you have the same mindset like @agilob?

agilob commented 8 years ago

I don't want application to decide when it accesses my device logs and starts getting GPS-fix because it was doing last time when I used it.