Smashing Bugs for WIP-Release v0.1.25-alpha

SecUpwN commented 10 years ago

Dear @xLaMbChOpSx, I know you have a rough time here. Another new Issue? Sigh - I'm sure you're not too happy about that. Furthermore, it appears that currently multiple Issues from previous WIP-Releases are cramped into one Issue, upgrading these to "Monster Issues" - that's NOT the fault of @E3V3A, but of the partially very fast development with new WIP-Releases in the middle. And that is a GOOD thing! But since you're currently pretty much alone on this journey (working to resolve that soon), I bet you're a little lost on what to work on.

Fret no more, here comes a cool new feature I'd like to take advantage of: Nested task lists!

So this is what I'll do with this new "Issue": I will review and ELIMINATE all "Monster Issues" (aka "v0.1.xx-alpha Bug Reports: Add your bugs here!") to comfortably list those Issues dragged from previous WIP-Releases up until now to be RESOLVED for WIP-Release 0.1.25 - this should allow for some time. And please, @xLaMbChOpSx, TAKE YOUR TIME! Really, I mean it. If you're upset about how things are being processed here, please talk to me on XDA. I'm a firm believer of the theory that god gave everyone a mouth to use it and to also voice constructive criticism. Please don't hesitate to tell me what you'd like to see changed.

@xLaMbChOpSx and @E3V3A, please help me on this to clear things up: Please TICK the things that are SOLVED! Thank you, folks. :sunflower:

Remember: When all these things are done, we're automatically at WIP-Release 0.1.25. Take it easy. We should also not forget to release the versions in the middle up until 0.1.25 fixing the other Issues.

Reported bugs from WIP-Release 0.1.8-alpha, Issue #44

[x] "Tracking signal strength" icon still show red cross, when tracking
[x] [Menu] --> "Show Map" starts map centered on the sea outside Togo (Africa)
[x] [Menu] --> Preferences --> Icon Theme is not showing the current theme selection
[x] All radio buttons are empty
[x] Returning from "Show Map" using "top-left slider area" disables all tracking
[x] Maps are not showing any cell towers (from OpenCellD)
[x] OpenCellID CSV file is empty (even after download)
[x] Exported CSV files contain many entries where only time stamp has changed
[x] Signal strength CSV is empty.

Reported bugs from WIP-Release 0.1.10-alpha, Issue #49

[x] Database Viewer: "Signal Strength Data" is empty, but warning is given
[x] Database Viewer: When "Cell Data" is selected and doesn't contain any data, no warning is given
[x] Show Map: Map starts at an "angle" where north is not up and map is not "flat"
[x] Map settings are not saved between views
[x] Updates of OpenCellID need to be downloaded again when going to the map
[ ] OpenCellID data seem irregular: Sometimes showing some towers at other times not
[ ] On main window, try to make some kind of indication of, when values have recently changed
[x] Do we have any measure about the polling time? I mean, how fast do these variables update?

Reported bugs from WIP-Release 0.1.11-alpha, Issue #53

[x] Database Viewer: "Cell Data" has entries with CellID = -1

Reported bugs from WIP-Release 0.1.13-alpha, Issue #58

[ ] Menu: "Update OpenCellID Data", gives the error message "Unable to determine your last location!"
[x] When disabling "tracking cell info", it should also disable "location tracking". But not vice versa.

Reported bugs from WIP-Release 0.1.14-alpha, Issue #62

[x] Map View: Current "Map Type" selection is not shown. (perhaps add a radio button?)
[ ] The "Update OpenCellID Data" function is not possible before enabling location tracking
[x] Re-implement the manual AT command entry from older version. Perhaps in a new slide page?
[x] Add automatic refresh of the "Cell Information" (ServiceMode data)
[x] Add a "Preferences" settings item for the refresh rate above. Something like:
Manual
MAX (as fast as possible) Warning: Leaving this on may consume excessive battery power
1s, 2s, 5s, 10s, 30s, 1min, 5 min, etc.
Automatic (when change is detected, should be default)

Bugs from WIP-Release 0.1.15-alpha, (not reported)

[x] When there is no mobile network coverage, the app crashes and FC's upon start.

Bugs from WIP-Release 0.1.16-alpha, (not reported)

[x] FC's when trying to view map on I9100 SlimKat 4.4.2. Just before FC, logcat shows several warnings from GooglePlayServicesUtil: "Google Play services out of date. Requires 4452000 but found 4325034."

Bugs from WIP-Release 0.1.17-alpha, (not reported)

[x] Doesn't let you update OpenCellID without locked location.
[x] Version number is still showing 0.1.16
[x] Are you sure you uploaded the right version?
[x] Refuses to close/quit no matter what the preferences settings

Bugs from WIP-Release 0.1.18-alpha, (not reported) On: S4-mini GT-I9195 stock 4.2.2 SELinux Enforcing

[x] Crashes upon startup: "Unfortunately Android IMSI-Catcher Detector has stopped.", but then starts anyway! (WTF?)
[x] Crashes upon "Quit" with same message as above, but then quits. (Those crashes seem random. Sometimes yes, sometimes no.)
[x] Crashes after hitting and completing "Backup database"
[x] Neighboring Cell Info broken
[x] "AT-interface": still not enabled
[x] "About AIMSICD": Background color of white text and blue text is different.
[x] "About AIMSICD": Most info links should take you to another (popup?) window with text and not to Github website. (OK for now.)
[x] Generates loads of Errors in Logcat from: _LocSvc_afw, LocSvceng and _LocSvcadapter
[x] "Settings:Refresh rate" item does not have an initial value shown. Should probably be Automatic. - [ ] "Settings:Refresh rate": Changing has no effect.
[x] Very "laggy"... need further investigation.

Summary: This version is harder to test on this device. Possibly because of the Enforcing mode, which prevent access to many file locations and other operations. More tests needed with SELinux settings in Enforcing versus Permissive modes, including setting full access to (via EFS files) to the ServiceMenu items.

On: GT-I9100, SlimKat 4.4.2b4

[x] Crashes on "Backup database"
[x] "Settings:Refresh rate": Changing has no effect.
[x] Attemting to download OCI DB crashes if no GPSlock has been found.

Summary: Most things that was causing crashes for the I9195 above, is working on this device, apart what is mentioned above. Neighboring cells look better and more clear. More testing needed. (I have a very bad battery and no gps-lock near outlet.)

Bugs from WIP-Release 0.1.19-alpha, (not reported) On: S4-mini GT-I9195 stock 4.2.2 SELinux Enforcing

[x] "Settings:Refresh rate": Changing has no effect.
[ ] "Neighboring Cells": Hitting refresh, doesn't update list, but only adds previous list (not being able to scroll down), but increments the cell count by one, every time.
[x] Crashes after "Quit" with the message: "Unfortunately Android IMSI-Catcher Detector has stopped.", and then closes. Relevant Logcat HERE.
[ ] "Neighboring Cells": Showing "funny code" for all cells. look like perhapsits the PSC ? Need further investigation, also a warning in logcat about length of something.

On: GT-I9100, SlimKat 4.4.2b4

[x] "Settings:Refresh rate": Changing has no effect.

Summary: Most things that was causing crashes for the I9195 before have been fixed, apart what is mentioned above.

Bugs from WIP-Release 0.1.20-alpha, (not reported)

General UI/UX improvements (all devices):

[x] UI: remove "line number" item from Device Information
[x] UI: Change "Network CellID" name to "Network CID" (or is there a another reason for using that?) and move it under "LAC" item. (These usually go together.)
[x] "About": Change the text background color to be the same as for the rest of the screen.
[ ] Install Buttons: Can we change them from "next to each other" to stacked? So that we can fit the text above next to the buttons?

On: GT-I9100, SlimKat 4.4.2b4

[ ] Funny behavior when using "Persistence" OFF and "Tracking" ON, and then trying to Quit, or stopping GPS. With the result that the app refuses to close.

On: S4-mini GT-I9195 stock 4.2.2 SELinux Enforcing

[ ] SU/Busybox checks should be done when opening Application and not later. (Unless necessary.)
[ ] "AT" works but output goes to the shell where cat /dev/smd0 & was issued... Need more test.
[x] There is this item called "Line Number" under Device Information. What is that? Do we need it? (On my phone it just shows the IMSI, which is already shown under SIM info.)
[ ] After "Quit" the App now refuses to shutdown, even though Persistence is OFF. Service issue. (?)

Bugs from WIP-Release 0.1.21-alpha, (not reported) GT-I9195:

[ ] Crashes when entering Map Viewer without initial GPS-lock/location
[x] Need roller/spinner for informing on the status of OCI download
[ ] DB:LocationData has 0x7FFFFFFF values (shown in dec) for CID and LAC
[ ] Cell Inforamtion:NeighboringCells has 0x7FFFFFFF values (shown in dec) for all fields
[ ] Cell Inforamtion:NeighboringCells show no indication of refresh

:exclamation: BUG ADD FREEZE - LET'S FOCUS ON FIXING ALL OF THESE. THANKS. ~~This list is subject to changes and / or deletions as we test them on our latest WIP-Release.~~

He3556 commented 10 years ago

I want to say BIG THANK'S to @xLaMbChOpSx ,too!! Really cool that you have time to spend on this project. Please let me know what you think about the implementation of https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/issues/91 when the time is right for you.

E3V3A commented 10 years ago

@xLaMbChOpSx Wow wow! Great to hear, and unless SecUpwN has already spilled his guts, we have more good news for you...

SecUpwN commented 10 years ago

I think I already sent @xLaMbChOpSx an E-Mail about my latest accomplishments.

E3V3A commented 10 years ago

@xLaMbChOpSx Bugs from WIP-Release 0.1.24-alpha, (not reported) On: GT-I9195: All issues remain the same as for 0.1.23 with the difference that the AT injector now doesn't work at all...

He3556 commented 10 years ago

On: HTC One M7 (rooted AOS 4.4.2)

[ ] Page "Cell Information": 1 neighbouring cell is shown 2 times in the list with LAC = 0 and a CellID i could not find with another App (RF Signal Tracker) i use to check.
[x] Page "Database Viewer" - "Cell Data": 1 Cell is shown 11 times, the lat/lon and sign. strength has a different values. After 10 mon. there is another Cell in the list.
[x] Page "Database Viewer" - "Location Data": when i click Load Data nothing happens.
[ ] Page "Get OpenCellID Data": Message - Error receiving data from OpenCellID

Do you need a logcat?

SecUpwN commented 10 years ago

This Issue keeps growing and growing. We need to stop this, now! @xLaMbChOpSx, since you've promised to erase all these within the upcoming week, let me know if you need anything!

xLaMbChOpSx commented 10 years ago

Another test version is available at my Dev-Host which should hopefully address the CID/LAC + other invalid display issues.

Uploading & Download methods for OpenCellID have been rewritten and tested ALTHOUGH our API key is not white-listed so is not allowing downloads, I did request a new key as suggested after the previous one was disclosed but it has not been white-listed as yet.

I also reverted two changes to the AT Command Injector to try and return its operation back to the state that was experienced with the v0.1.21 release, if there are still issues I can revert all AT Command changes right back to that version to hopefully restore the previous level of stability.

xLaMbChOpSx commented 10 years ago

Newer build is available

E3V3A commented 10 years ago

Ok, so the problem with not being able to download the OCID data is because we don't have a key. Bad. I don't have time to contact "them" right now. Would it be possible to obtain a personal key that can be used in app? Perhaps a way for each user to get his/her own? By entering somewhere in App?

Yeah, the AT is behaving weird, or not at all. I have no idea what is going on there. Also there are 2 /dev/smd0 devs listed on mine... Also for eveyone's info, I think you'll have to reboot phone if you've used it previously, since the smd0 device access is "blocked" by whatever PID it was using. AT least that's what happens on command line. The way to see it is using: jobs -a. Or does the app take care of that?

PS. Please also make sure you change the version in the app, just so that we can make sure we're running the right one. Easy to make mistakes...

SecUpwN commented 10 years ago

@E3V3A, if I read that right, @xLaMbChOpSx has already requested a new key with https://github.com/SecUpwN/Android-IMSI-Catcher-Detector/commit/c2dc93bceb3c818162495e96714a33d58dd9a7c0 and I'm sure it will be included within the next release. Regarding the AT Command Injector: My ROM seems to lack the binary radio, rather another binary radio_feedback is available. I'm not sure if that's the same binary under a different name - renaming radio_feedback to radio did not cause any Issues. How to validate if it's the same? Finally for the version number: I know that @xLaMbChOpSx keeps changing that as thoroughly as possible, but I propose the following two things for a better overview:

Add the version number to the main screen aside "AIMSICD" (it says AIMSICD 0.1.24-alpha then)
Change the strings method so that only one place has to be edited to change the current versioning both on the main screen as well as in the About-Section. That should simply things a bit.

E3V3A commented 10 years ago

@SecUpwN I really have no idea what you're talking about there. You have a binary called "radio" in your /system/bin/ ??

Also, I suggest that for minimal and incremental updates that are produced, that their names are appended with something like:

AIMSICD 0.1.24-alpha_b1
AIMSICD 0.1.24-alpha_b2

etc.

E3V3A commented 10 years ago

@xLaMbChOpSx You posted several minor test version updates, can you also write one line what issue you tried to address on those (or what change we should expect), so we know what to look for?

2014-08-13 http://d-h.st/zHX (?)
2014-08-19 http://d-h.st/4jG (CID/LAC display issues)
2014-08-19 http://d-h.st/93J (???)

You can edit this post.

SecUpwN commented 10 years ago

@E3V3A, my idea was simply to add the version number to the main screen beneath the word "AIMSICD" as well to make it more easy finding it. By adding some sort of "master string", both the version number of the main screen as well as in the About-Tab should be changeable: Means, only change the "master string" to change the version number across the whole App.

Regarding my issue with radio: Yes, I do not have the binary radio in my ROM, just a binary called radio_feedback. And now I wanted to know how to test if that is actually my "radio".

Regarding the versioning of minor incremental updates: I think it is a good idea to explain what the minimal changes are, but since they are minor updates and no real releases, don't you think that this just places another hurdle in development onto the shoulders of developers? Not sure about this. If you really like the nameing of AIMSICD 0.1.24-alpha_b1 and such, ok - but they can stay on Dev-Host and the link + explanation posted in the relevant Issue, we don't need another branch for that.

E3V3A commented 10 years ago

Well, alphas imho, is all about minor updates, but without an ongoing discussion with developer about what is being fixed and not, it is impossible to test in any sensible manner. We need more feedback here.

SecUpwN commented 10 years ago

The current internal test release solved one more bug on my device. I am happy to notice that the list is melting! @xLaMbChOpSx and @andr3jx could you please be so nice to digg into the remaining list to fix these?

xLaMbChOpSx commented 10 years ago

Proposed some more changes in #112 including rewritten AT Command Injection, notification icon display corrections and correct handling of location services (GPS) settings with Cell Tracking enabled.

AT Command Injection does not work on either of my devices so requires testing but I am hoping these changes at least restore the earlier level of functionality.

A compiled version for testing can be found here

E3V3A commented 10 years ago

@xLaMbChOpSx Found bugs, AT need fixin', please see #23.

E3V3A commented 10 years ago

Bugs for WIP-Release 0.1.24-alpha_b6

On: GT-I9195: (See device details here.)

[ ] AT Command Injector: Not working, see previous post.
[x] Cell Information: force close!
[x] Crashes when entering Map Viewer without initial GPS-lock/location.
[x] Change Network Information text of "Primary Scrambling Code" to "PSC".
[ ] Change Settings text of "Cell Information" to "Neighbouring Cells". (If that is the correct intention of this?)
[ ] Database Viewer: In "Cell Data" and "Location Data", non available signal strength is shown as "2147483647" (0x7FFFFFFF)
[x] Database Viewer: In "Cell Data" and "Location Data", change display names from: "CellID" to "CID" "Latitude" to "LAT" "Longitude" to "LON" "Signal Strenths" to "RSSI"
[ ] When the service restarts after FC's, the app starts with "Monitoring Cell Details" turned off. Make sure its ON, if the user had it ON.
[x] Returning from Map Viewer, stops "Monitoring Cell Details". (At least when OCID is not available.)
[ ] Clarify the difference between: "Device Details" and "Lookup Current Cell Details"

On: GT-I9100:

[x] Crashes when entering "Map Viewer" without initial GPS-lock/location

SecUpwN commented 9 years ago

@tobykurien, if you have a "free minute" (yeah, I know..), can you see if you can tackle some of the remaining Issues here? I am sure those are interconnected to other separate Issues we've already filed on our GitHub - once solved, we'll have cleared up another huge bunch of junk. Thank you so much!

@E3V3A and @andr3jx, please use the current build of our App to check against all remaining Issues here. I want this to be SOLVED, please don't add any new Issues here, rather open new ones. Thanks!

E3V3A commented 9 years ago

@SecUpwN All issues here are outdated, miss understood, fixed or not applicable to the latest development version v0.1.25-alpha-b3. So let's close this issue and get on with the latest bug-list. I know this is a bit out of our reular rules of operation, but since the last alphas has had so many changes, it is more messy trying to track all old issues down and check, rather than just starting to check on latest version from scratch. Which is also why we need to start using a testing protocol as in #173.

SecUpwN commented 9 years ago

See I knew this would happen. We create monster Issues like this, I try to track and reverify everything for every version and and then you just close it because it is too much work and outdated. Have you even tried to check all these bugs again, @E3V3A? Because the way I see it, we will end up double-listing them again. :angry:

E3V3A commented 9 years ago

Yes, I did check them, did you?

SecUpwN commented 9 years ago

Yes, I did check them, did you?

For the majority, yes. But the most Issues you filed here are difficult to check because I cannot see what you did on certain occasions. Should we really let this be closed and check from the ground up?

E3V3A commented 9 years ago

I did try to check them from ground up, only to discover what I said above. In some cases the issues were not well worded and defined which means that parts of it has been fixed and others not.

CellularPrivacy / Android-IMSI-Catcher-Detector

Smashing Bugs for WIP-Release v0.1.25-alpha #65