CellularPrivacy / Android-IMSI-Catcher-Detector

AIMSICD • Fight IMSI-Catcher, StingRay and silent SMS!
https://cellularprivacy.github.io/Android-IMSI-Catcher-Detector/
GNU General Public License v3.0
4.68k stars 941 forks source link

Replace removed ProgressBar with more stable Indicator #678

Open SecUpwN opened 8 years ago

SecUpwN commented 8 years ago

After removing the glitchy ProgressBar with #673, I consider it important to now re-add a more stable visual Indicator. I've digged through many projects and collected some ideas. Feel free to add yours!

SmoothProgressBar


MaterialLoadingProgressBar


android-PullRefreshLayout


SwipyRefreshLayout


Android-MaterialRefreshLayout

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

larsgrefer commented 8 years ago

We already have a SwipeRefreshLayout: http://developer.android.com/reference/android/support/v4/widget/SwipeRefreshLayout.html So there is no need for an extra dependency i think

SecUpwN commented 8 years ago

We already have a SwipeRefreshLayout

@larsgrefer, are projects like Ultra-Pull-To-Refresh and MaterialProgressBar of use for us?

larsgrefer commented 8 years ago

Everything we would need from Ultra-Pull-To-Refresh is the material style we already have in the support-v4 library.

Our progressbars are already material styled by the appcompat-v7 library

So imho we don't need any extra libraries at the moment

SecUpwN commented 8 years ago

So imho we don't need any extra libraries at the moment

Hm.. so why don't we have a progress indicator showing then? :P

larsgrefer commented 8 years ago

Be patient

SecUpwN commented 8 years ago

Be patient

Sorry, I will.

SecUpwN commented 8 years ago

Seems like everyone is very busy these days. @CellularPrivacy/design please help to fix this. Reading https://github.com/CellularPrivacy/Android-IMSI-Catcher-Detector/issues/678#issuecomment-163327400 and https://github.com/CellularPrivacy/Android-IMSI-Catcher-Detector/issues/678#issuecomment-167161732, it appears that we do not need to add more depencies, but just enhance the existing pull-to-refresh to work across our whole app. Comments are very welcome.