search

CellularPrivacy / Android-IMSI-Catcher-Detector

AIMSICD • Fight IMSI-Catcher, StingRay and silent SMS!
https://cellularprivacy.github.io/Android-IMSI-Catcher-Detector/
GNU General Public License v3.0
4.68k stars 941 forks source link

Clicking a link on credits stops auto-scrolling and it never resumes #846

Open agilob opened 8 years ago

agilob commented 8 years ago

but at least I can scroll up now!

SecUpwN commented 8 years ago

Honestly speaking, these "bugs" are things that E:V:A always hated since they are no real Issues. But hey, at least I am happy you're testing our app so hardcore. Adding you to the testers team now. ;-)

@VladThodo, please fix this bug as well when working on #839. Thank you very much!

agilob commented 8 years ago

these "bugs" are things that E:V:A always hated since they are no real Issues

If UI of the application is not intuitive, bad or causes crashes... how can I trust it with more serious issues like IMSI-CD? Smelly code stays for longer. Those are real issues and very important ones.

VladThodo commented 8 years ago

@SecUpwN Unterstood :) I will try to fix these issues

mimi89999 commented 8 years ago

This can be achieved by removing https://github.com/CellularPrivacy/Android-IMSI-Catcher-Detector/blob/development/AIMSICD/src/main/java/com/secupwn/aimsicd/ui/activities/AboutActivity.java#L168 , but I don't think it's a good idea.

mimi89999 commented 8 years ago

I tested it and I think it's really a bad idea not to stop scrolling.

SecUpwN commented 8 years ago

I tested it and I think it's really a bad idea not to stop scrolling.

So does that mean we should remove L168 now?

mimi89999 commented 8 years ago

No

SecUpwN commented 8 years ago

No

@VladThodo will fix both mentioned Issues. @mimi89999 please tell him what tzhe solution would be.

mimi89999 commented 8 years ago

I think that it should be possible for the user to stop autoscrooling in some way. @SecUpwN You can remove this line and build the app. Then, you can open credits and click on one link to see if such a behaviour is really the expected one...