Celtoys / Remotery

Single C file, Realtime CPU/GPU Profiler with Remote Web Viewer
Apache License 2.0
3.03k stars 255 forks source link

MINGW-64 does not seem to define _M_AMD64 or _M_X64 #247

Closed Redhacker1 closed 12 months ago

Redhacker1 commented 12 months ago

On MINGW (in both CLion's built-in MINGW-64 and MYSYS2) I keep receiving compiler errors stemming from code that seems to only be built in non 64-bit configurations. When changing #ifdef _M_AMD64 to #if defined(_M_AMD64) || defined(__x86_64__) on line 143 of Remotery.h everything works and compiles fine (provided you link the required libs with your build system as GCC does not support pragma comment).

Without that MINGW-64 seems to define RMT_ARCH_32BIT instead of RMT_ARCH_64BIT as it should

Redhacker1 commented 12 months ago

welp, the fix was merged (did not expect that so fast)