CensoredUsername / dynasm-rs

A dynasm-like tool for rust.
https://censoredusername.github.io/dynasm-rs/language/index.html
Mozilla Public License 2.0
716 stars 52 forks source link

Arch::name() unused. #93

Open vext01 opened 6 months ago

vext01 commented 6 months ago

I noticed:

warning: method `name` is never used
  --> plugin/src/arch/mod.rs:13:8
   |
12 | pub(crate) trait Arch : Debug + Send {
   |                  ---- method in this trait
13 |     fn name(&self) -> &str;
   |        ^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: field `name` is never read
  --> plugin/src/arch/mod.rs:22:5
   |
21 | pub struct DummyArch {
   |            --------- field in this struct
22 |     name: &'static str
   |     ^^^^
   |
   = note: `DummyArch` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Did you want to kill the method entirely?

CensoredUsername commented 6 months ago

It's plugin internal, so you can just kill it.

vext01 commented 6 months ago

Indeed. I just wanted to check I wasn't bulldozing something you wanted to keep around. Thanks.