search

CensoredUsername / unrpyc

A ren'py script decompiler
Other
837 stars 149 forks source link

Added alternative behavior if multiprocessing module is missing #112

Closed madeddy closed 3 years ago

madeddy commented 3 years ago

Like talked about in #106

CensoredUsername commented 3 years ago

There's a lot of changes in that file seemingly not related to your code but just changing random formatting, could you restrict the pull to just the actual changes necessary?

madeddy commented 3 years ago

A lot? The empty lines where just from some autoformat feat for py styleguide/pep8. I tested VScode again for usability as i did the changes. Normally i am in Atom. Removed all the spaces, though i think it's formatting is not useless. Please check and write what you think.

jackmcbarn commented 3 years ago

A lot? The empty lines where just from some autoformat feat for py styleguide/pep8. I tested VScode again for usability as i did the changes. Normally i am in Atom. Removed all the spaces, though i think it's formatting is not useless. Please check and write what you think.

The problem with those blank lines isn't that they're useless; it's that they're unrelated to the purpose of this PR. If you want, you could make a separate PR that makes all of unrpyc be PEP8-compliant.

madeddy commented 3 years ago

Ah,ok. This can i completely understand and see the use of it. Thanks for explaining. In this case i should also fit the formatting of the one argparse option to the others.

CensoredUsername commented 3 years ago

I squashed and rebased stuff onto dev to get rid of the 4 bugfix commits, and did some cleanup. It's now mainlined!